Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Surveymonkey source: fix gzip compressed http response caching #5983

Merged
merged 2 commits into from
Sep 12, 2021
Merged

🐛 Surveymonkey source: fix gzip compressed http response caching #5983

merged 2 commits into from
Sep 12, 2021

Conversation

avida
Copy link
Contributor

@avida avida commented Sep 10, 2021

What

Resolves #5982

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 10, 2021
@avida
Copy link
Contributor Author

avida commented Sep 10, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-surveymonkey

🕑 connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/1221353923
✅ connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/1221353923

@jrhizor jrhizor temporarily deployed to more-secrets September 10, 2021 13:15 Inactive
yevhenii-ldv
yevhenii-ldv reviewed Sep 10, 2021
View reviewed changes
...ntegrations/connectors/source-surveymonkey/source_surveymonkey/schemas/survey_questions.json
},
"validation": {
"type": "string"
"type": ["string", "null"]
},
"forced_ranking": {
"type": "boolean"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You admit that 4 properties can be Null, are you sure that the rest of the properties cannot be Null too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest of the properties are required for request (or they have default value) hence they would always be present on output

https://developer.surveymonkey.com/api/v3/#surveys-id-pages-id-questions

yevhenii-ldv
yevhenii-ldv reviewed Sep 10, 2021
View reviewed changes
airbyte-integrations/connectors/source-surveymonkey/source_surveymonkey/spec.json
@@ -11,8 +11,8 @@
"title": "Start Date",
"type": "string",
"description": "The date from which you'd like to replicate the data",
"pattern": "^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}Z$",
"examples": "2021-01-01T00:00:00Z"
"pattern": "^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}Z?$",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my understanding: in what cases can we miss an error with ^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}Z$, but validate it with ^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}Z?$?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Z is not required anymore

@avida avida requested a review from sherifnada September 10, 2021 14:37
Zirochkaa
Zirochkaa approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@Zirochkaa Zirochkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs/integrations/sources/surveymonkey.md Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-surveymonkey/acceptance-test-config.yml Outdated Show resolved Hide resolved
@sherifnada sherifnada changed the title Surveymonkey source: fix gzip compressed http response caching 🐛 Surveymonkey source: fix gzip compressed http response caching Sep 10, 2021
@avida
Copy link
Contributor Author

avida commented Sep 12, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-surveymonkey

🕑 connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/1226857718
✅ connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/1226857718

@jrhizor jrhizor temporarily deployed to more-secrets September 12, 2021 16:03 Inactive
@avida avida merged commit 6ec45b3 into master Sep 12, 2021
@avida avida deleted the drezchykov/surveymonkey-fix branch September 12, 2021 16:09
@jrhizor jrhizor mentioned this pull request Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@Zirochkaa Zirochkaa Zirochkaa approved these changes

@yevhenii-ldv yevhenii-ldv yevhenii-ldv approved these changes

@htrueman htrueman Awaiting requested review from htrueman

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SAT fails for surveymonkey connector
5 participants
@avida @sherifnada @Zirochkaa @yevhenii-ldv @jrhizor