Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Shopify: Fixed line_items/discount allocations & duties parts of orders schema #5801

Merged
merged 3 commits into from
Sep 2, 2021

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Sep 2, 2021

What

#5739 - Basic normalization problems with Shopify -> Snowflake

How

Added the orders / line_items / discount_allocations schema, that was missing.
Added orders / line_items / duties schema, that was missing.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

@bazarnov bazarnov self-assigned this Sep 2, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Sep 2, 2021
@bazarnov bazarnov changed the title 🐛 Source Shopify: Fixed discount allocations & duties parts of orders schema 🐛 Source Shopify: Fixed line_items/discount allocations & duties parts of orders schema Sep 2, 2021
@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/protocol CDK Connector Development Kit labels Sep 2, 2021
@bazarnov bazarnov linked an issue Sep 2, 2021 that may be closed by this pull request
@bazarnov bazarnov requested a review from antixar September 2, 2021 09:36
@bazarnov
Copy link
Collaborator Author

bazarnov commented Sep 2, 2021

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1193673850
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1193673850

@jrhizor jrhizor temporarily deployed to more-secrets September 2, 2021 09:48 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Sep 2, 2021

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1193707660
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1193707660

@jrhizor jrhizor temporarily deployed to more-secrets September 2, 2021 10:01 Inactive
@bazarnov bazarnov merged commit 9c05308 into master Sep 2, 2021
@bazarnov bazarnov deleted the bazarnov/shopify-discount-allocations-fix branch September 2, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation area/protocol CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic normalization problems with Shopify->Snowflake
3 participants