Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-file: adding support to XLSB format #5613

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

muutech
Copy link
Contributor

@muutech muutech commented Aug 25, 2021

What

Support for binary excel files (pyxslb). See #5576

How

Add in setup.py library pyxlsb

Recommended reading order

N/A

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 25, 2021
@marcosmarxm
Copy link
Member

Awesome @muutech it's possible to add a note/improve the docs to other users know about this new feature?

@muutech
Copy link
Contributor Author

muutech commented Aug 25, 2021

From our point of view is already quite documented, since it is mentioned that you can pass to Pandas "reader_options": https://docs.airbyte.io/integrations/sources/file#reader-options This is just a reader_option ("engine") that didn't work because of a missing library. More info here: https://pandas.pydata.org/pandas-docs/stable/user_guide/io.html#io-excel-reader

If you think some docs or notes should be added tell us where or what and we will do :)

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @muutech

@marcosmarxm marcosmarxm merged commit ad22ee6 into airbytehq:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants