Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Cart.com: add order_items stream #5582

Merged
merged 3 commits into from
Aug 24, 2021

Conversation

marcosmarxm
Copy link
Member

What

Closes #5511 and correct CI because spec.json example wasn't an array...

How

Add order_items stream to access products inside orders.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 23, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 23, 2021

Works running local with normalization enabled. Querying destinatoin database.
Screenshot from 2021-08-23 17-56-48
Screenshot from 2021-08-23 17-57-11

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 23, 2021

/test connector=connectors/source-cart

🕑 connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1160210488
❌ connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1160210488

@jrhizor jrhizor temporarily deployed to more-secrets August 23, 2021 21:01 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 23, 2021

/test connector=connectors/source-cart

🕑 connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1160376489
❌ connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1160376489

@jrhizor jrhizor temporarily deployed to more-secrets August 23, 2021 22:00 Inactive
@marcosmarxm
Copy link
Member Author

This is blocked by #5465 @sherifnada can you help me here? Should I publish without tests?

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcosmarxm feel free to release without tests if needed, should be fixed in the PR you linked. But make sure to update the configured catalog in integration_tests so the tests run on this stream

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Aug 24, 2021

/publish connector=connectors/source-cart run-tests=false

🕑 connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1160981484
✅ connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1160981484

@jrhizor jrhizor temporarily deployed to more-secrets August 24, 2021 02:28 Inactive
@marcosmarxm marcosmarxm merged commit 93032a8 into master Aug 24, 2021
@marcosmarxm marcosmarxm deleted the marcosmarxm/add-order-items-stream-cart branch August 24, 2021 02:38
avida pushed a commit that referenced this pull request Aug 25, 2021
* add order_items stream

* run format

* add order_items in integration_tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/cart connectors/sources-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Cart.com: add products in order stream
4 participants