Load CDK: Drop vestigial obj storage staging stuff #54661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
johnny-schmidt
force-pushed
the
jschmidt/load-cdk/generic-path-factory
branch
from
2a663ea to
34a8bb7
Compare
johnny-schmidt
force-pushed
the
jschmidt/load-cdk/generic-path-factory
branch
from
34a8bb7 to
68fcb88
Compare
octavia-squidington-iii
added
the
area/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
NON-FUNCTIONAL CODE CLEANUP
This drops the remaining references to staging in the object storage toolkit. (Staging was an abortive attempt at fixing the issues with metadata search as part of the S3V2 release. We disabled it, and subsequent changes have rendered the existing code moot, so it's better to drop it than to give the false impression that it is useful.)
Why
In addition to cleanup
So I'm going to clean up / simplify the configuration a little bit so that not everybody is burdened by S3's insane legacy path rules.