🐛 Source Apple Search Ads: fix daily stream granularity #53685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sheinbergon is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
|
|
octavia-squidington-iii
added
area/connectors
sheinbergon
had a problem deploying
to
community-ci-auto
GitHub Actions
Failure
sheinbergon
had a problem deploying
to
community-ci
GitHub Actions
Error
sheinbergon
had a problem deploying
to
community-ci
GitHub Actions
Error
1 task
natikgadzhi
reviewed
Feb 14, 2025
| @@ -211,7 +211,7 @@ definitions: | |||
| "ASCENDING" } ] } | |||
| timeZone: UTC | |||
| startTime: "{{ stream_slice.start_time }}" | |||
| granularity: "{{ parameters.granularity }}" | |||
| granularity: DAILY | |||
|
/bump-version type="patch" changelog="Fix granularity to daily"
|
natikgadzhi
approved these changes
Feb 14, 2025
octavia-squidington-iii
added
the
area/documentation
octavia-approvington
temporarily deployed
to
community-ci
GitHub Actions
Inactive
octavia-approvington
temporarily deployed
to
community-ci
GitHub Actions
Inactive
octavia-approvington
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sheinbergon
deleted the
sheinbergon/apple-search-ads-daily-granularity-fix
branch
|
@natikgadzhi 10x, better close the linked issue #48573 |
|
@natikgadzhi Also, when can I expect an official updated connector release? |
|
They usually get published in 10-15m after being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes broken daily granularity stream (See #48573)
How
Granularity for daily streams is paramaterized, it should just be set to daily
Review guide
manifest.yamlhas been updated to refelect no parameterized granularityUser Impact
Daily breakdown streams will work (they are currently broken)
Can this PR be safely reverted and rolled back?