Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Service Account Instruction #53633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Service Account Instruction #53633

wants to merge 1 commit into from
+5 −3

Conversation

hchiao1
Copy link

@hchiao1 hchiao1 commented Feb 11, 2025

job pod service account customization

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@hchiao1
Update Service Account Instruction
3faf3b5 
job pod service account customization
@vercel Vercel
Copy link

vercel bot commented Feb 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 6:24pm

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 11, 2025
JonsSpaghetti
JonsSpaghetti requested changes Feb 11, 2025
View reviewed changes
docs/enterprise-setup/implementation-guide.md
Comment on lines -750 to -751
serviceAccount:
name:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this still needs to exist as well, we want both. One service account for airbyte pods and one service account for the job pods unless I'm mistaken. Maybe @bgroff or @perangel can confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonsSpaghetti JonsSpaghetti JonsSpaghetti requested changes

@bgroff bgroff Awaiting requested review from bgroff

@Conall-airbyte Conall-airbyte Awaiting requested review from Conall-airbyte

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hchiao1 @CLAassistant @JonsSpaghetti @octavia-squidington-iii