Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean out unused "bases" and utils #53234

Merged
merged 2 commits into from
Feb 7, 2025
Merged

chore: clean out unused "bases" and utils #53234

merged 2 commits into from
Feb 7, 2025

Conversation

natikgadzhi
Copy link
Contributor

What

This PR removes more unused old code:

  • airbyte-integrations/scripts had two scripts that we no longer use
  • airbyte-integrations/bases had two Dockerfile-based container build scripts (base and base_java) that were not in use for about 2 years.
  • normalization bases went away too.

@natikgadzhi natikgadzhi requested a review from a team as a code owner February 7, 2025 23:05
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 11:09pm

Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brings happy tears to my eyes. 🥹

I can't be final approver on it, but yes, I do agree with these removals. My understanding is that most of these dependencies have been migrated now to newer implementations / CDKs.

@natikgadzhi natikgadzhi merged commit 4dec57a into master Feb 7, 2025
24 checks passed
@natikgadzhi natikgadzhi deleted the ng/cleanup branch February 7, 2025 23:19
@natikgadzhi
Copy link
Contributor Author

I can't be final approver on it

Auto-merge says you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants