Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Instagram: updating media and mediainsights fields #53214

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Source Instagram: updating media and mediainsights fields #53214

wants to merge 5 commits into from

Conversation

hromit
Copy link

@hromit hromit commented Feb 7, 2025 •
edited
Loading

What

Updating media & mediainsights stream with new available fields.

How

Updated Manifest.yaml with new fields & updated schema.

Review guide

  1. manifest.yaml, media_insights.json
  2. updated unit test cases

User Impact

  • What is the end result perceived by the user?
  • users should be able to consume new fields.

Can this PR be safely reverted and rolled back?

  • If unsure, leave it blank.
  • YES 💚

@vercel Vercel
Copy link

vercel bot commented Feb 7, 2025

Someone is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hromit hromit temporarily deployed to community-ci-auto February 7, 2025 00:08 — with GitHub Actions Inactive
@hromit hromit temporarily deployed to community-ci-auto February 7, 2025 10:52 — with GitHub Actions Inactive
@marcosmarxm
Copy link
Member

Can you provide an issue links to Instagram documentation page showing these fields?

@hromit
Copy link
Author

hromit commented Feb 7, 2025 •
edited
Loading

Can you provide an issue links to Instagram documentation page showing these fields?

Sure @marcosmarxm

Media Stream

MediaInsights Stream

Attaching screenshots as well.
mediainsights-stream
media_stream

@natikgadzhi
Copy link
Contributor

natikgadzhi commented Feb 8, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (471ead5)

@natikgadzhi
Copy link
Contributor

@hromit thank you for this!

@DanyloGL can you please run a regression test on this too and see if there are any problems with it? Otherwise the code changes look fine to me.

@DanyloGL DanyloGL temporarily deployed to community-ci-auto February 10, 2025 14:14 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues community connectors/source/instagram
Projects
🧑‍🏭 Community Pull Requests
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hromit @CLAassistant @marcosmarxm @natikgadzhi @octavia-squidington-iii @octavia-approvington @DanyloGL