Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination S3: reenable assume role test; fix file transfer test? #53147

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Feb 4, 2025

(just looking for a rubberstamp, will merge on green CI)

  • update the base fakeFileTransfer test to match the new error message
  • reenable the assume role legacy DAT
  • reenable a bunch of disabled test cases?

@edgao edgao requested a review from johnny-schmidt February 4, 2025 00:56
@edgao edgao requested a review from a team as a code owner February 4, 2025 00:56
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 1:01am

@edgao edgao enabled auto-merge (squash) February 4, 2025 16:33
@edgao edgao merged commit 0113c14 into master Feb 4, 2025
31 checks passed
@edgao edgao deleted the edgao/s3_tests branch February 4, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/destination/s3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants