[S3-data-lake] Add rest catalog integration tests #53141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
|
/format-fix
|
edgao
approved these changes
Feb 4, 2025
...st-integration/kotlin/io/airbyte/integrations/destination/s3_data_lake/RestTestContainers.kt
Show resolved
Hide resolved
| // so just poll until these methods stop throwing exceptions | ||
| while (true) { | ||
| try { | ||
| testcontainers.getServicePort("spark-iceberg", 8080) |
There was a problem hiding this comment.
in retrospect - probably should have
- deleted the spark container
- and just called
getServicePort(minio); getServicePort(rest)here
(not a blocker here, since we're not planning to rely on these tests 🤷 )
...t-integration/kotlin/io/airbyte/integrations/destination/s3_data_lake/S3DataLakeWriteTest.kt
Show resolved
Hide resolved
edgao
reviewed
Feb 5, 2025
| "catalog_type": { | ||
| "catalog_type": "REST", | ||
| "server_uri": "http://$restEndpoint:8181", | ||
| "namespace": "test" |
There was a problem hiding this comment.
fyi - after #53186 merges, we should change this to "namespace": "<DEFAULT_NAMESPACE_PLACEHOLDER>"
…est-integration/kotlin/io/airbyte/integrations/destination/s3_data_lake/RestTestContainers.kt Co-authored-by: Edward Gao <[email protected]>
…est-integration/kotlin/io/airbyte/integrations/destination/s3_data_lake/S3DataLakeWriteTest.kt Co-authored-by: Edward Gao <[email protected]>
octavia-squidington-iii
added
the
area/documentation
|
/format-fix
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding integration tests around the rest catalog
Can this PR be safely reverted and rolled back?