Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve regression test status urls to point to test reports #52688

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve regression test status urls to point to test reports #52688

wants to merge 1 commit into from
+3 −3

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 31, 2025 •
edited
Loading

What

  • Update regression test status URLs to point to GCS test reports instead of static documentation or workflow URLs
  • Add clearer description when tests are skipped due to no connector changes

Why

The current status check links are not useful:

  • Manual approval points to static documentation
  • Auto-skip points to workflow run with no clear action

This change makes the links point to actual test reports in GCS which contain detailed test results.

Requested by: @aaronsteers

Link to Devin run: https://app.devin.ai/sessions/a520d0e79f034170bcae32ccbc24c3a0

@devin-ai-integration @aaronsteers
improve regression test status urls to point to test reports
754c3b1 
- Update approve-regression-tests-command.yml to point to GCS test report
- Update connectors_tests.yml to point to GCS test report and improve skip description
- Both changes make the status check more useful by linking to actual test results

Co-Authored-By: Aaron <AJ> Steers <[email protected]>
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner January 31, 2025 17:46
@vercel Vercel
Copy link

vercel bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 5:53pm

@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

Original prompt from Aaron:

@Devin - Find the CI job in the monorepo that generates this text: "<https://github.com/airbytehq/airbyte/actions/runs/13059329825|Regression Test Results Reviewed and Approved>"

The link is useless right now - it points to a random job that is in 'success' status, with no CTA and no clear action for the reader to take. If we can change it to point to something useful, that would be great.

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@octavia-squidington-iii