[source volcano] Allow field to be used as CDC cursor #52677
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rodireich
approved these changes
Jan 31, 2025
burakku
force-pushed
the
volcano-cdc-partition
branch
from
012dc6c to
7939951
Compare
burakku
force-pushed
the
volcano-cdc-partition
branch
from
7939951 to
c5db712
Compare
burakku
force-pushed
the
volcano-cdc-partition
branch
from
c5db712 to
8c96cb8
Compare
burakku
force-pushed
the
volcano-cdc-partition
branch
2 times, most recently
from
a6ea75e to
f5f5a92
Compare
burakku
force-pushed
the
volcano-cdc-partition
branch
from
f5f5a92 to
b0d7b17
Compare
burakku
force-pushed
the
volcano-cdc-partition
branch
from
b0d7b17 to
b2e44d1
Compare
burakku
force-pushed
the
volcano-cdc-partition
branch
from
b2e44d1 to
cbc6e46
Compare
burakku
changed the title
burakku
force-pushed
the
volcano-cdc-partition
branch
from
cbc6e46 to
29367f3
Compare
karolur
pushed a commit
to karolur/airbyte
that referenced
this pull request
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As we add trigger based CDC for Sap Hana, existing CDK does not support this use case.
Here is the conflict in CDK:
If we define trigger table schema using meta field type, we cannot query the table. If we define trigger table schema using field type, we cannot define the cursor at discovery phase.
How
So we either change SelectQuerySpec to support meta field type or we change MetaFieldDecorator to support field type as cursor.
I would prefer to change SelectQuerySpec but that involves much larger scope of change so I'm only update MetaFieldDecorator for now
Review guide
User Impact
No
Can this PR be safely reverted and rolled back?