Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Load CDK: micronaut nonsense #52627

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Bulk Load CDK: micronaut nonsense #52627

merged 4 commits into from
Jan 29, 2025

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jan 29, 2025

https://airbytehq-team.slack.com/archives/C081G34EA21/p1738168904767559

  • am very confused about this app-test.yaml situation - tests run fine on my machine (TM) without this file
  • this assume role thing is stupid, see comments for explanation
    • this was causing tests to hang, but I don't understand how your app-test thing would have affected it

@edgao edgao requested a review from a team as a code owner January 29, 2025 16:55
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 9:04pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jan 29, 2025
@edgao edgao enabled auto-merge (squash) January 29, 2025 20:58
@edgao edgao merged commit ae01f28 into master Jan 29, 2025
29 checks passed
@edgao edgao deleted the edgao/micronaut_nonsense branch January 29, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/s3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants