Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source hubspot: correctly use logger exception printing #5250

Merged
merged 6 commits into from
Aug 6, 2021

Conversation

sherifnada
Copy link
Contributor

@sherifnada sherifnada commented Aug 6, 2021

What

This was causing a crash

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@sherifnada
Copy link
Contributor Author

/publish connector=connectors/source-hubspot

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 6, 2021
@sherifnada
Copy link
Contributor Author

sherifnada commented Aug 6, 2021

/publish connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1105693911
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1105693911

@jrhizor jrhizor temporarily deployed to more-secrets August 6, 2021 16:10 Inactive
Copy link
Contributor

@Zirochkaa Zirochkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just small comment

@sherifnada
Copy link
Contributor Author

sherifnada commented Aug 6, 2021

/publish connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1106016024
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1106016024

@jrhizor jrhizor temporarily deployed to more-secrets August 6, 2021 18:19 Inactive
@sherifnada sherifnada merged commit 8e74551 into master Aug 6, 2021
@sherifnada sherifnada deleted the sherif/hubspot branch August 6, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants