-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source google spreadsheets: fix error during listing sheets with diagram only #5233
Source google spreadsheets: fix error during listing sheets with diagram only #5233
Conversation
…ix-lists-with-diagrams
…eadsheet-fix-lists-with-diagrams' into midavadim/2202-source-google-spreadsheet-fix-lists-with-diagrams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Lines up as described in Sheets API doc here to only grab relevant sheets 👍
/test connector=connectors/source-google-sheets
|
/test connector=connectors/source-google-sheets
|
/test connector=connectors/source-google-sheets
|
/publish connector=connectors/source-google-sheets |
/publish connector=connectors/source-google-sheets
|
What
ERROR during sync of sheets with diagram only
{"type": "LOG", "log": {"level": "INFO", "message": "Starting syncing spreadsheet 1cec2856fH1qsMXysi1pwDT-a3f_ZZRo0dPvw7ZC3GW4"}}
Traceback (most recent call last):
File "main_dev.py", line 33, in
launch(source, sys.argv[1:])
File "/home/vratniuk/air/airbyte/airbyte-integrations/bases/base-python/base_python/entrypoint.py", line 121, in launch
AirbyteEntrypoint(source).start(args)
File "/home/vratniuk/air/airbyte/airbyte-integrations/bases/base-python/base_python/entrypoint.py", line 112, in start
for message in generator:
File "/home/vratniuk/air/airbyte/airbyte-integrations/connectors/source-google-sheets/google_sheets_source/google_sheets_source.py", line 132, in read
sheet_row_counts = Helpers.get_sheet_row_count(client, spreadsheet_id)
File "/home/vratniuk/air/airbyte/airbyte-integrations/connectors/source-google-sheets/google_sheets_source/helpers.py", line 173, in get_sheet_row_count
return {sheet.properties.title: sheet.properties.gridProperties["rowCount"] for sheet in spreadsheet_metadata.sheets}
File "/home/vratniuk/air/airbyte/airbyte-integrations/connectors/source-google-sheets/google_sheets_source/helpers.py", line 173, in
return {sheet.properties.title: sheet.properties.gridProperties["rowCount"] for sheet in spreadsheet_metadata.sheets}
AttributeError: 'SheetProperties' object has no attribute 'gridProperties'
How
Filter our sheets with no 'gridProperties' attr
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes