Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source google spreadsheets: fix error during listing sheets with diagram only #5233

Conversation

midavadim
Copy link
Contributor

@midavadim midavadim commented Aug 5, 2021

What

ERROR during sync of sheets with diagram only

{"type": "LOG", "log": {"level": "INFO", "message": "Starting syncing spreadsheet 1cec2856fH1qsMXysi1pwDT-a3f_ZZRo0dPvw7ZC3GW4"}}
Traceback (most recent call last):
File "main_dev.py", line 33, in
launch(source, sys.argv[1:])
File "/home/vratniuk/air/airbyte/airbyte-integrations/bases/base-python/base_python/entrypoint.py", line 121, in launch
AirbyteEntrypoint(source).start(args)
File "/home/vratniuk/air/airbyte/airbyte-integrations/bases/base-python/base_python/entrypoint.py", line 112, in start
for message in generator:
File "/home/vratniuk/air/airbyte/airbyte-integrations/connectors/source-google-sheets/google_sheets_source/google_sheets_source.py", line 132, in read
sheet_row_counts = Helpers.get_sheet_row_count(client, spreadsheet_id)
File "/home/vratniuk/air/airbyte/airbyte-integrations/connectors/source-google-sheets/google_sheets_source/helpers.py", line 173, in get_sheet_row_count
return {sheet.properties.title: sheet.properties.gridProperties["rowCount"] for sheet in spreadsheet_metadata.sheets}
File "/home/vratniuk/air/airbyte/airbyte-integrations/connectors/source-google-sheets/google_sheets_source/helpers.py", line 173, in
return {sheet.properties.title: sheet.properties.gridProperties["rowCount"] for sheet in spreadsheet_metadata.sheets}
AttributeError: 'SheetProperties' object has no attribute 'gridProperties'

How

Filter our sheets with no 'gridProperties' attr

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 5, 2021
@midavadim midavadim changed the title Source google sheets: fix error during listing sheets with diagram only Source google spreadsheets: fix error during listing sheets with diagram only Aug 5, 2021
…eadsheet-fix-lists-with-diagrams' into midavadim/2202-source-google-spreadsheet-fix-lists-with-diagrams
@midavadim midavadim requested review from antixar and lazebnyi August 5, 2021 21:23
Copy link
Contributor

@Phlair Phlair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Lines up as described in Sheets API doc here to only grab relevant sheets 👍

@midavadim
Copy link
Contributor Author

midavadim commented Aug 9, 2021

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1113142284
❌ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1113142284

@jrhizor jrhizor temporarily deployed to more-secrets August 9, 2021 14:16 Inactive
@midavadim
Copy link
Contributor Author

midavadim commented Aug 10, 2021

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1115596400
❌ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1115596400

@jrhizor jrhizor temporarily deployed to more-secrets August 10, 2021 06:38 Inactive
@midavadim
Copy link
Contributor Author

midavadim commented Aug 11, 2021

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1120793417
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1120793417

@jrhizor jrhizor temporarily deployed to more-secrets August 11, 2021 16:17 Inactive
@midavadim
Copy link
Contributor Author

/publish connector=connectors/source-google-sheets

@midavadim
Copy link
Contributor Author

midavadim commented Aug 11, 2021

/publish connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1121151029
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/1121151029

@jrhizor jrhizor temporarily deployed to more-secrets August 11, 2021 18:17 Inactive
@midavadim midavadim merged commit fd52290 into master Aug 11, 2021
@midavadim midavadim deleted the midavadim/2202-source-google-spreadsheet-fix-lists-with-diagrams branch August 11, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Google Spreadsheet: charts in a separate google sheet break syncing
6 participants