allow scheduling getspec workers #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherifnada
requested review from
jrhizor,
michel-tricot and
cgardens
and removed request for
jrhizor and
michel-tricot
sherifnada
commented
Oct 8, 2020
| }, | ||
| }, | ||
| } | ||
| --- |
There was a problem hiding this comment.
unrelated to the PR but noticed that this was json not yaml so i fixed it
| @@ -78,22 +82,23 @@ public WorkerRun create(final Job job) { | |||
| LOGGER.info("job root: {}", jobRoot); | |||
|
|
|||
| switch (job.getConfig().getConfigType()) { | |||
| case CHECK_CONNECTION_SOURCE: | |||
| case CHECK_CONNECTION_DESTINATION: | |||
| case CHECK_CONNECTION_SOURCE, CHECK_CONNECTION_DESTINATION -> { | |||
There was a problem hiding this comment.
using jdk14 switch
michel-tricot
approved these changes
Oct 8, 2020
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allows the scheduler to schedule GetSpec workers.