Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source-intercom): incremental not emitting state #52132

Merged
merged 8 commits into from
Jan 29, 2025
Merged

fix(source-intercom): incremental not emitting state #52132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a23739b
updated base image
darynaishchenko Jan 24, 2025
af9f15f
updated changelog
darynaishchenko Jan 24, 2025
88b9c9e
fix get_stream_state
darynaishchenko Jan 27, 2025
ec51f89
updated baseImage
darynaishchenko Jan 27, 2025
7db8e40
updated version in manifest
darynaishchenko Jan 27, 2025
cc16159
removed activity_logs from incremental testing
darynaishchenko Jan 28, 2025
8a3dc5e
updated base image
darynaishchenko Jan 29, 2025
a1f47c6
updated version in manifest
darynaishchenko Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-intercom/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def _get_request_option(self, option_type: RequestOptionType, stream_slice: Stre
return {}

def get_stream_state(self) -> StreamState:
return self._state
return self._state.copy()

def select_state(self, stream_slice: Optional[StreamSlice] = None) -> Optional[StreamState]:
return self.get_stream_state()
Expand Down
11 changes: 0 additions & 11 deletions airbyte-integrations/connectors/source-intercom/integration_tests/abnormal_state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,5 @@
"updated_at": 7626086649
}
}
},
darynaishchenko marked this conversation as resolved.
Show resolved Hide resolved
{
"type": "STREAM",
"stream": {
"stream_descriptor": {
"name": "activity_logs"
},
"stream_state": {
"created_at": 7626086649
}
}
}
]
14 changes: 0 additions & 14 deletions airbyte-integrations/connectors/source-intercom/integration_tests/incremental_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,5 @@
{
"streams": [
{
"stream": {
"name": "activity_logs",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["created_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"cursor_field": ["created_at"],
"primary_key": [["id"]],
"destination_sync_mode": "append"
},
{
"stream": {
"name": "companies",
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-intercom/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: 5.14.0
version: 6.28.0

definitions:
## bases
Expand Down
5 changes: 2 additions & 3 deletions airbyte-integrations/connectors/source-intercom/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ data:
hosts:
- api.intercom.io
connectorBuildOptions:
baseImage: docker.io/airbyte/source-declarative-manifest:5.14.0@sha256:accdf6c1bbcabd45b40f836692e4f3b1a1e1f0b28267973802ee212cd9c2c16a
baseImage: docker.io/airbyte/source-declarative-manifest:6.28.0@sha256:6935048f02debe2cd6e33707b1f6885fc620914ef49ac00af75220ee7a596adf
connectorSubtype: api
connectorType: source
definitionId: d8313939-3782-41b0-be29-b3ca20d8dd3a
dockerImageTag: 0.9.0
dockerImageTag: 0.10.0
dockerRepository: airbyte/source-intercom
documentationUrl: https://docs.airbyte.com/integrations/sources/intercom
githubIssueLabel: source-intercom
Expand All @@ -28,7 +28,6 @@ data:
registryOverrides:
cloud:
enabled: true
dockerImageTag: 0.8.3
oss:
enabled: true
releaseStage: generally_available
Expand Down
Loading
Loading