Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-mysql: adopt bulk-cdk-toolkit-extract-cdc API changes #52039

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Jan 20, 2025

What

Adopts changes made in the Bulk CDK with #52040 and #52051 in source-mysql.

How

n/a

Review guide

See the PRs this one is based on.

User Impact

None.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 8:59pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/source/mysql labels Jan 20, 2025
@postamar postamar changed the base branch from master to postamar/bulk-cdk-extract-cdc-improvements January 20, 2025 21:37
@postamar postamar marked this pull request as ready for review January 20, 2025 21:49
@postamar postamar requested a review from a team as a code owner January 20, 2025 21:49
@postamar postamar force-pushed the postamar/bulk-cdk-extract-cdc-improvements branch from 37e4428 to 1565204 Compare January 20, 2025 21:50
@postamar postamar force-pushed the postamar/source-mysql-cdc-api-changes branch from 20b0c68 to 4b78fef Compare January 20, 2025 21:50
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Jan 20, 2025
import io.airbyte.cdk.read.cdc.DebeziumOffset
import io.airbyte.cdk.read.cdc.DebeziumOperations
import io.airbyte.cdk.read.cdc.DebeziumPropertiesBuilder
import io.airbyte.cdk.read.cdc.DebeziumRecordKey
import io.airbyte.cdk.read.cdc.DebeziumRecordValue
import io.airbyte.cdk.read.cdc.DebeziumSchemaHistory
import io.airbyte.cdk.read.cdc.DebeziumState
import io.airbyte.cdk.read.cdc.DebeziumWarmStartState
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is a "warm" start state?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a starting state from which Debezium can resume quickly, as opposed to a cold start state where it needs to rebuild the database's schema history

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this particular change is in #52040

@postamar postamar force-pushed the postamar/source-mysql-cdc-api-changes branch from 4b78fef to f75f3b6 Compare January 21, 2025 12:56
@postamar postamar force-pushed the postamar/source-mysql-cdc-api-changes branch from f75f3b6 to b81c7a1 Compare January 21, 2025 17:26
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jan 21, 2025
@postamar postamar changed the base branch from postamar/bulk-cdk-extract-cdc-improvements to postamar/bulk-cdk-state-manager-changes January 21, 2025 17:26
@postamar postamar force-pushed the postamar/bulk-cdk-state-manager-changes branch from a7b0926 to 8d53eb1 Compare January 21, 2025 17:36
@postamar postamar force-pushed the postamar/source-mysql-cdc-api-changes branch from b81c7a1 to 459746c Compare January 21, 2025 17:37
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Jan 21, 2025
@octavia-squidington-iv octavia-squidington-iv requested review from a team January 28, 2025 16:30
@postamar postamar force-pushed the postamar/bulk-cdk-state-manager-changes branch from f869af8 to 02d7609 Compare January 30, 2025 18:27
@postamar postamar force-pushed the postamar/source-mysql-cdc-api-changes branch from 459746c to 3377f97 Compare January 30, 2025 18:28
@postamar postamar force-pushed the postamar/bulk-cdk-state-manager-changes branch from 02d7609 to dc3476a Compare January 30, 2025 18:47
Base automatically changed from postamar/bulk-cdk-state-manager-changes to master January 30, 2025 19:02
@postamar postamar force-pushed the postamar/source-mysql-cdc-api-changes branch from 3377f97 to a466eb0 Compare January 30, 2025 20:53
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 30, 2025
@postamar postamar enabled auto-merge (squash) January 30, 2025 20:54
@postamar postamar merged commit 8c2ed63 into master Jan 30, 2025
31 of 32 checks passed
@postamar postamar deleted the postamar/source-mysql-cdc-api-changes branch January 30, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mysql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants