-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up protocol definition files & change to yamlschema #514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it to be yaml for readability purposes but I am ok moving back to Json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to change gradle to not expect yamlschema
I removed repetition of the file name in self-references across all of the types and switched everything to use yaml. I also cleaned up paths that were confusing when scoped with "json". |
Interesting gotcha: the folder for |
"$ref": airbyte_schema.yaml#/definitions/AirbyteStream
to a valid"$ref": #/definitions/AirbyteStream