Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up protocol definition files & change to yamlschema #514

Merged
merged 10 commits into from
Oct 7, 2020

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Oct 7, 2020

  • convert to json for consistency
  • make the names of the files match the exact title of the schema
  • change the invalid reference "$ref": airbyte_schema.yaml#/definitions/AirbyteStream to a valid "$ref": #/definitions/AirbyteStream

@jrhizor jrhizor requested a review from michel-tricot October 7, 2020 18:26
Copy link
Contributor

@michel-tricot michel-tricot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it to be yaml for readability purposes but I am ok moving back to Json.

Copy link
Contributor

@michel-tricot michel-tricot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change gradle to not expect yamlschema

@jrhizor
Copy link
Contributor Author

jrhizor commented Oct 7, 2020

I removed repetition of the file name in self-references across all of the types and switched everything to use yaml. I also cleaned up paths that were confusing when scoped with "json".

@jrhizor jrhizor changed the title clean up protocol definition files clean up protocol definition files & change to yamlschema Oct 7, 2020
@jrhizor
Copy link
Contributor Author

jrhizor commented Oct 7, 2020

Interesting gotcha: the folder for singer_types can't be named types since it'll get clobbered by the other resources/types.

@jrhizor jrhizor merged commit ee487c1 into master Oct 7, 2020
@jrhizor jrhizor deleted the jrhizor/clean-up-protocol-files branch October 7, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants