🐛 Source S3: fixed bug in spec so that Format field displays in UI correctly #5135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/connectors
|
/test connector=connectors/source-s3
|
sherifnada
approved these changes
Aug 2, 2021
marcosmarxm
approved these changes
Aug 2, 2021
|
/publish connector=connectors/source-s3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Pydantic doesn't generate
type: objectfor ananyOffield meaningFormatpart of UI wasn't rendering correctly. Added this into the manual post-processing of the pydantic schema and now works as intended.Note: I think I missed this before because when testing spec locally in UI it seems to cache the spec and not update on changes automatically. Tested this time using hard refresh but this isn't particularly obvious, especially when only making minor changes.