[destination-motherduck] append batch tmp table instead replace during override #50425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
guenp
reviewed
Dec 26, 2024
...e-integrations/connectors/destination-motherduck/destination_motherduck/processors/duckdb.py
Show resolved
Hide resolved
Co-authored-by: Guen Prawiroatmodjo <[email protected]>
guenp
reviewed
Dec 26, 2024
...e-integrations/connectors/destination-motherduck/destination_motherduck/processors/duckdb.py
Show resolved
Hide resolved
|
/format-fix
|
aaronsteers
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Changes look good! Great job with the quick turnaround for this fix, @marcosmarxm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
If your data exceeds 50k, the Motherduck destination will
overridethe previous temporary table with the new batch. Since the logic involves dropping and cleaning the table first, we can apply the same logic asappendingbecause the table is empty.How
Review guide
User Impact
Can this PR be safely reverted and rolled back?