Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs for default port in typesense connector #49984

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

soumilbaldota
Copy link
Contributor

What

This fixes the doc for the default connector port for the typesense connector.
It is by default 8108 in the connector code, but it was 443 in the docs.

How

Change the doc to say the default port is 8108

Review guide

  1. "description": "Port of the Typesense instance. Ex: 8108, 80, 443. Default is 443",
  2. node = {"host": host, "port": config.get("port") or "8108", "protocol": config.get("protocol") or "https"}

User Impact

Users can connect to typesense using airbyte when their typesense instance is secured with ssl, and only port 443 is open.
This should improve this connector's reliability stats amongst ssl users.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Dec 21, 2024

@soumilbaldota is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@soumilbaldota
Copy link
Contributor Author

@natikgadzhi I have made the fix to the docs as recommended, could you review/authorize it?

@soumilbaldota
Copy link
Contributor Author

Can someone review this?

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 4, 2025
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:44pm

@marcosmarxm marcosmarxm enabled auto-merge (squash) February 4, 2025 17:38
@marcosmarxm marcosmarxm merged commit 74890da into airbytehq:master Feb 4, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/typesense
Projects
Development

Successfully merging this pull request may close these issues.

3 participants