-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docs for default port in typesense connector #49984
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@soumilbaldota is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
2 tasks
@natikgadzhi I have made the fix to the docs as recommended, could you review/authorize it? |
Can someone review this? |
marcosmarxm
approved these changes
Feb 4, 2025
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
community
connectors/destination/typesense
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This fixes the doc for the default connector port for the typesense connector.
It is by default 8108 in the connector code, but it was 443 in the docs.
How
Change the doc to say the default port is 8108
Review guide
airbyte/airbyte-integrations/connectors/destination-typesense/destination_typesense/spec.json
Line 27 in d02c1ea
airbyte/airbyte-integrations/connectors/destination-typesense/destination_typesense/destination.py
Line 22 in d02c1ea
User Impact
Users can connect to typesense using airbyte when their typesense instance is secured with ssl, and only port 443 is open.
This should improve this connector's reliability stats amongst ssl users.
Can this PR be safely reverted and rolled back?