Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle timestamp without timezone in iceberg #49854

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix: handle timestamp without timezone in iceberg #49854

merged 2 commits into from
Dec 18, 2024
+12 −2

Conversation

subodh1810
Copy link
Contributor

No description provided.

@subodh1810 subodh1810 requested a review from edgao December 18, 2024 04:55
@subodh1810 subodh1810 self-assigned this Dec 18, 2024
@subodh1810 subodh1810 requested a review from a team as a code owner December 18, 2024 04:55
@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 5:20am

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Dec 18, 2024
@subodh1810 subodh1810 mentioned this pull request Dec 18, 2024
Merged
@subodh1810 subodh1810 changed the title fix: handle timestamp without timezone fix: handle timestamp without timezone in iceberg Dec 18, 2024
@subodh1810 subodh1810 mentioned this pull request Dec 18, 2024
Merged
edgao
edgao approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

(haven't tested against my branch, but seems reasonable - feel free to merge, if it continues failing I can probably figure it out from here)

@subodh1810 subodh1810 merged commit 189925f into master Dec 18, 2024
36 checks passed
@subodh1810 subodh1810 deleted the fix-timestam-without-timezone-iceberg branch December 18, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees

@subodh1810 subodh1810

Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/destination/iceberg-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subodh1810 @edgao @octavia-squidington-iii