Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Source-Stripe - Fix for Customer_Balance_Transaction records occasionally getting missed #49811

Conversation

williamkaper
Copy link
Contributor

@williamkaper williamkaper commented Dec 16, 2024

What

  • This PR fixes Issue 48857 - customer balance transactions get missed.

How

  • I've changed the stream type from UpdatedCursorIncrementalStripeSubStream to ParentIncrementalStripeSubStream. The previous implementation used an event type that didn't pertain to customer balance transactions by mistake. Now the stream doesn't have any updated component, so the legacy cursor field was removed. I tested and now records are no longer dropped.

Review guide

  1. metadata.yml - version bump
  2. pyproject.toml - version bump
  3. source-stripe/source.yml - changed the stream type and removed the legacy cursor field
  4. stripe.md - Updated the documentation
  5. erd/discovered_catalog.json - removed updated
  6. erd/source.dbml - removed updated
  7. integration_tests/abnormal_state.json - changed updated to created
  8. integration_tests/configured_catalog.json - removed updated

User Impact

  • Customer balance transactions are no longer dropped
  • Unrelated update events don't drive update behavior.
  • The updated column is removed.

Can this PR be safely reverted and rolled back?

I believe so assuming column backfill is enabled.

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Dec 16, 2024

@williamkaper is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/stripe labels Dec 16, 2024
@williamkaper williamkaper changed the title First attempt at a fix 🐛Source-Stripe - Fix for Customer_Balance_Transaction records occasionally getting missed Dec 16, 2024
@williamkaper
Copy link
Contributor Author

williamkaper commented Dec 16, 2024

@maxi297 PR Per our conversation last week

@marcosmarxm for visibility

#48857 (comment)

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 7:18pm

Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the change. Thanks for the PR @williamkaper

@maxi297 maxi297 merged commit 559cac7 into airbytehq:master Dec 16, 2024
36 checks passed
barduinor pushed a commit to box-community/airbyte that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/stripe
Projects
Development

Successfully merging this pull request may close these issues.

[source-stripe] Customer_Balance_Transaction records are occasionally getting missed
3 participants