Bulk Load CDK: Unwrap multipart streaming upload #48810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
tryangul
reviewed
Dec 4, 2024
| private val streamProcessor: StreamProcessor<T>, | ||
| private val wrappingBuffer: T | ||
| ) : ObjectStorageFormattingWriter { | ||
| override val numCapturedChanges: AtomicLong = writer.numCapturedChanges |
There was a problem hiding this comment.
What is this for? I only see it used for logging?
There was a problem hiding this comment.
Yes, it's some of what I added for testing, but if feels like useful information.
tryangul
reviewed
Dec 4, 2024
|
|
||
| fun isDataSufficient(): Boolean { | ||
| return buffer.size() >= partSize | ||
| } |
There was a problem hiding this comment.
Nit: this seems orthogonal to the buffered writer. Since it's called strictly externally, we can easily pull this out.
There was a problem hiding this comment.
Yeah, it should just be a size check.
tryangul
reviewed
Dec 5, 2024
| metadata: Map<String, String> | ||
| ): StreamingUpload<S3Object> { | ||
| // TODO: Remove permit handling once we control concurrency with # of accumulators | ||
| if (uploadPermits != null) { |
There was a problem hiding this comment.
Should we go ahead and move the semaphore upstream to get it out of the client code at least?
tryangul
approved these changes
Dec 5, 2024
johnny-schmidt
force-pushed
the
jschmidt/load-cdk/separate-processing-from-upload
branch
from
c44bb77 to
c0dcc58
Compare
|
I also ripped out the logging. |
johnny-schmidt
force-pushed
the
jschmidt/load-cdk/separate-processing-from-upload
branch
from
c0dcc58 to
5000a21
Compare
johnny-schmidt
force-pushed
the
jschmidt/load-cdk/separate-processing-from-upload
branch
4 times, most recently
from
a8f42b9 to
6b486f6
Compare
johnny-schmidt
force-pushed
the
jschmidt/load-cdk/separate-processing-from-upload
branch
from
6b486f6 to
7f0a7ae
Compare
johnny-schmidt
deleted the
jschmidt/load-cdk/separate-processing-from-upload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is a first step toward separating processing from uploading
BufferingFormattedWriterthat wraps the Avro/Json/Csv/Parquet writers, accumulating the records and yielding complete parts