metadata-service[orchestrator]: ensure RC are always newer than current version in the registry #46735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
clnoll
approved these changes
Oct 11, 2024
| release_candidate_registry_entry.dockerImageTag: to_json_sanitized_dict(release_candidate_registry_entry) | ||
| } | ||
| updated_registry_entry = copy.deepcopy(latest_registry_entry) | ||
| updated_registry_entry.setdefault("releases", {}) |
There was a problem hiding this comment.
Should this go above the updated_registry_entry["releases"]["releaseCandidates"] line?
alafanechere
force-pushed
the
augustin/10-11-metadata-service_orchestrator_ensure_RC_are_always_newer_than_current_version_in_the_registry
branch
from
2953e0d to
66cc446
Compare
…nt version in the registry
alafanechere
force-pushed
the
augustin/10-11-metadata-service_orchestrator_ensure_RC_are_always_newer_than_current_version_in_the_registry
branch
from
66cc446 to
6386e0d
Compare
alafanechere
deleted the
augustin/10-11-metadata-service_orchestrator_ensure_RC_are_always_newer_than_current_version_in_the_registry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We want to guarantee that the RC exposed in the connector registry are always newer compared to the main version.
This simplifies the RC promotion logic as we won't need to delete the previous RC registry entry to remove it from the final registry.
How
Parse RC and main version with semver.
Compare them.
Only nest RC when RC version > main version.