Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Greenhouse: faster check stream #45625

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

etiennecallies
Copy link
Contributor

What

Fixes #45411 + a minor typo in connector's README.md.

How

In the issue, I mentioned skip_count parameter, but it would require to create a new stream, that would be used only for check. I preferred to change the stream check from applications to users, as there are far less users than applications. In a company there are indeed more applicants than recruiters.

User Impact

Normally, there always are some users, therefore check should always pass. By the way, it is more likely to have some users and no applications, than no users and some applications.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 5:06pm

@etiennecallies
Copy link
Contributor Author

Before the fix:

(airbyte) 15:53:23 ~/airbyte/airbyte-integrations/connectors/source-greenhouse (source-greenhouse *) $ time poetry run source-greenhouse check --config secrets/config.json
{"type": "LOG", "log": {"level": "INFO", "message": "Check succeeded"}}
{"type": "CONNECTION_STATUS", "connectionStatus": {"status": "SUCCEEDED"}}

real	0m37.324s
user	0m0.948s
sys	0m0.154s

After the fix:

(airbyte) 15:56:24 ~/airbyte/airbyte-integrations/connectors/source-greenhouse (source-greenhouse *) $ time poetry run source-greenhouse check --config secrets/config.json
{"type": "LOG", "log": {"level": "INFO", "message": "Check succeeded"}}
{"type": "CONNECTION_STATUS", "connectionStatus": {"status": "SUCCEEDED"}}

real	0m2.167s
user	0m0.964s
sys	0m0.150s

@etiennecallies etiennecallies changed the title [source-greenhouse] #45411 change check stream 🐛 Source Greenhouse : faster check stream Sep 17, 2024
@etiennecallies etiennecallies changed the title 🐛 Source Greenhouse : faster check stream 🐛 Source Greenhouse: faster check stream Sep 17, 2024
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @etiennecallies ! LGTM

@marcosmarxm
Copy link
Member

Running CI tests

@marcosmarxm marcosmarxm merged commit 6502f92 into airbytehq:master Sep 17, 2024
35 checks passed
@etiennecallies etiennecallies deleted the source-greenhouse branch September 18, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/greenhouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[source-greenhouse] Check fails as API timeouts
3 participants