-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Greenhouse: faster check stream #45625
Merged
marcosmarxm
merged 3 commits into
airbytehq:master
from
etiennecallies:source-greenhouse
Sep 17, 2024
Merged
🐛 Source Greenhouse: faster check stream #45625
marcosmarxm
merged 3 commits into
airbytehq:master
from
etiennecallies:source-greenhouse
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
Before the fix:
After the fix:
|
marcosmarxm
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch @etiennecallies ! LGTM
Running CI tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
community
connectors/source/greenhouse
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #45411 + a minor typo in connector's README.md.
How
In the issue, I mentioned
skip_count
parameter, but it would require to create a new stream, that would be used only for check. I preferred to change the stream check fromapplications
tousers
, as there are far less users thanapplications
. In a company there are indeed more applicants than recruiters.User Impact
Normally, there always are some users, therefore check should always pass. By the way, it is more likely to have some users and no applications, than no users and some applications.
Can this PR be safely reverted and rolled back?