Destination Iceberg: Fix tests to run in airbyte-ci #45206
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gisripa
force-pushed
the
gireesh/09-06-iceberg-fix-tests
branch
3 times, most recently
from
b73fdbb to
1c4c687
Compare
octavia-squidington-iii
added
the
area/documentation
gisripa
force-pushed
the
gireesh/09-06-iceberg-fix-tests
branch
from
1c4c687 to
57417ac
Compare
gisripa
force-pushed
the
gireesh/09-06-iceberg-fix-tests
branch
from
57417ac to
3aa0d8a
Compare
gisripa
changed the title
gisripa
force-pushed
the
gireesh/09-06-iceberg-fix-tests
branch
from
3aa0d8a to
f96665c
Compare
| @Override | ||
| protected String getDefaultSchema(@NotNull JsonNode config) throws Exception { | ||
| // TODO: This was NPE'ing without this return value because of Kotlin's non-null in base, | ||
| // but whats the actual value to pass instead of empty ? |
There was a problem hiding this comment.
make the function abstract?
There was a problem hiding this comment.
where are we inheriting this as nonnullable from? DAT.kt says it returns String? on master https://github.com/airbytehq/airbyte/blob/master/airbyte-cdk/java/airbyte-cdk/db-destinations/src/testFixtures/kotlin/io/airbyte/cdk/integrations/standardtest/destination/DestinationAcceptanceTest.kt#L261
There was a problem hiding this comment.
Bad comment, actually was doing !! in actual tests for defaultSchema which was set as null in base class.
| @Override | ||
| protected String getDefaultSchema(@NotNull JsonNode config) throws Exception { | ||
| // TODO: This was NPE'ing without this return value because of Kotlin's non-null in base, | ||
| // but whats the actual value to pass instead of empty ? |
There was a problem hiding this comment.
where are we inheriting this as nonnullable from? DAT.kt says it returns String? on master https://github.com/airbytehq/airbyte/blob/master/airbyte-cdk/java/airbyte-cdk/db-destinations/src/testFixtures/kotlin/io/airbyte/cdk/integrations/standardtest/destination/DestinationAcceptanceTest.kt#L261
gisripa
force-pushed
the
gireesh/09-06-iceberg-fix-tests
branch
from
f96665c to
a93eb06
Compare
gisripa
force-pushed
the
gireesh/09-06-iceberg-fix-tests
branch
from
a93eb06 to
9e69d3d
Compare
gisripa
force-pushed
the
gireesh/09-06-iceberg-fix-tests
branch
from
9e69d3d to
ed9adc3
Compare
What
Fixing tests, reconfiguring docker ports to run in airbyte-ci environment.
How
Review guide
MinioContainerToDelete.MinioContainerfor reusing the dependency in other catalogs.host-portto use container network vs host network depending on connector run calls vs test runner calls.User Impact
Can this PR be safely reverted and rolled back?