Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR 4038 #4067

Merged
merged 6 commits into from
Jun 14, 2021
Merged

Test PR 4038 #4067

merged 6 commits into from
Jun 14, 2021

Conversation

marcosmarxm
Copy link
Member

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in output spec
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Documentation updated
    • README
    • CHANGELOG.md
    • Reference docs in the docs/integrations/ directory.
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jun 11, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jun 11, 2021

/test connector=destination-s3

🕑 destination-s3 https://github.com/airbytehq/airbyte/actions/runs/930093552
❌ destination-s3 https://github.com/airbytehq/airbyte/actions/runs/930093552

@github-actions github-actions bot added area/connectors Connector related issues and removed area/documentation Improvements or additions to documentation labels Jun 14, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jun 14, 2021

/test connector=destination-s3

🕑 destination-s3 https://github.com/airbytehq/airbyte/actions/runs/937355254
✅ destination-s3 https://github.com/airbytehq/airbyte/actions/runs/937355254

@marcosmarxm marcosmarxm requested a review from tuliren June 14, 2021 22:19
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jun 14, 2021

/publish connector=connectors/destination-s3

🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/937367954
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/937367954

@marcosmarxm
Copy link
Member Author

@tuliren PR #4038 was merged without releasing the new version for the S3 destination connector. Can you validate this one?

@marcosmarxm marcosmarxm merged commit a721429 into master Jun 14, 2021
@marcosmarxm marcosmarxm deleted the marcosmarxm/test-pr-4038 branch June 14, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants