Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS S3 and Alternative S3 destination connector feature #4038

Merged
merged 7 commits into from
Jun 13, 2021
Merged

AWS S3 and Alternative S3 destination connector feature #4038

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e57f679
base from prev PR
panhavad Jun 10, 2021
4051b2c
add s3 alternative destination connector feature
Chensokheng Jun 10, 2021
1dfe8b8
fix testGetOutputFilename
panhavad Jun 10, 2021
874db87
default using aws
panhavad Jun 11, 2021
d0d37fa
Update airbyte-integrations/connectors/destination-jdbc/src/main/java…
panhavad Jun 13, 2021
5b3b32c
Update airbyte-integrations/connectors/destination-s3/src/main/java/i…
panhavad Jun 13, 2021
cea1018
fix missing ","
panhavad Jun 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ination-jdbc/src/main/java/io/airbyte/integrations/destination/jdbc/copy/s3/S3Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public static S3Config getS3Config(JsonNode config) {
partSize = config.get("part_size").asInt();
}
return new S3Config(
config.get("s3_endpoint").asText(),
config.get("s3_endpoint") == null ? "" : config.get("s3_endpoint").asText()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuliren did you forget ","

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right.

config.get("s3_bucket_name").asText(),
config.get("access_key_id").asText(),
config.get("secret_access_key").asText(),
Expand Down