Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Souce Amplitude Refactor: Use CheckpointMixin for state management #39103

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Jun 4, 2024

What

Resolves #8187

Updates source Amplitude to use CheckpointMixin for state management. get_updated_state is converted to a private method and invoked by the state setter.

User Impact

No impact. Regression tests results

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 3:01pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 4, 2024
@ChristoGrab ChristoGrab marked this pull request as ready for review June 6, 2024 15:33
@ChristoGrab ChristoGrab requested a review from a team June 6, 2024 15:33
@ChristoGrab ChristoGrab merged commit c1de750 into master Jun 6, 2024
35 checks passed
@ChristoGrab ChristoGrab deleted the christo/amplitude/state branch June 6, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amplitude
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants