Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Notion Refactor: implement CheckpointMixin for state handling #38798

Merged
merged 6 commits into from
Jun 6, 2024

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented May 30, 2024

What

Resolves #39323

Implements CheckpointMixin class for handling state in the Python blocks stream, and converts deprecated get_updated_state to a private method to be invoked in the state setter.

User Impact

No impact. Live test results.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 5:19pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 4, 2024
@ChristoGrab ChristoGrab changed the title Source Notion: migrate get_updated_state to Mixin Source Notion Refactor: implement CheckpointMixin for state handling Jun 4, 2024
@ChristoGrab ChristoGrab marked this pull request as ready for review June 6, 2024 17:15
@ChristoGrab ChristoGrab requested a review from a team June 6, 2024 17:21
@ChristoGrab ChristoGrab merged commit 4d7242b into master Jun 6, 2024
37 checks passed
@ChristoGrab ChristoGrab deleted the christo/notion/state branch June 6, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/notion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Notion: Implement CheckpointMixin
4 participants