Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale action for open issues #36468

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Conversation

marcosmarxm
Copy link
Member

This PR adds 2 stale actions:

  • issues without frozen label not updated in 180+ days and close after 20 days (currently 280 issues)
  • issues with frozen label not updated in 365+ days and close after 20 days(currently 0 issues)

@marcosmarxm marcosmarxm requested review from bleonard and a team March 25, 2024 22:41
Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 5:37pm

- uses: actions/stale@v5
with:
any-of-labels: "community"
exempt-issue-labels: "frozen"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like maybe there are some more exempt ones here and below. The ones that comes to mind the ones that are still on the roadmap. https://github.com/orgs/airbytehq/projects/37/views/1
We could run scripts to tag those automatically.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if there are multiple tags here like roadmap and somethingelse or there should just be one like evergreen or something.

Copy link
Member Author

@marcosmarxm marcosmarxm Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roadmap issues are usually created by the Airbyte team and won't have the community label.
The any-of-labels ensure this action will be applied to only community labeled issues any other it's internal won't be applied.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is frozen exempt though. Just so it doesn't compete with the other timeline? What about ones from the community that are ebing worked on. Maybe those get assigned and stuff so they don't get stale?

steps:
- uses: actions/stale@v5
with:
any-of-labels: "frozen"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it only apply stale action to issues were triaged by the engineering teams.
Roadmap and other issues I don't think will be enter this workflow.

Copy link
Contributor

@bleonard bleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, whatever you think. Go for it.

- uses: actions/stale@v5
with:
any-of-labels: "community"
exempt-issue-labels: "frozen"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is frozen exempt though. Just so it doesn't compete with the other timeline? What about ones from the community that are ebing worked on. Maybe those get assigned and stuff so they don't get stale?

@marcosmarxm marcosmarxm merged commit 5e51b26 into master Apr 10, 2024
31 checks passed
@marcosmarxm marcosmarxm deleted the marcos/stale-action-for-issues branch April 10, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants