Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [source-orb] add end date parameter #36288

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

marcosmarxm
Copy link
Member

For accounts with a lot of data it isn't manageable to ingest all data from Orb because of how their API works.
The idea is to give the end_date parameter to users so they can have a better control to run syncs.

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2024 4:49pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/orb labels Mar 19, 2024
Copy link
Contributor

@alex-gron alex-gron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so we can test this change.
I am not sure if this will fix our specific issue, but it shouldn't hurt anything to add it as an optional parameter to the connector

@marcosmarxm marcosmarxm merged commit 374771c into master Mar 22, 2024
30 checks passed
@marcosmarxm marcosmarxm deleted the marcos/orb-add-end-date branch March 22, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/orb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants