🐛 Source Orb: fix window request for credit_ledger_entries
#36036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
marcosmarxm
changed the title
credit_ledger_entries
alex-gron
reviewed
Mar 13, 2024
| @@ -38,6 +38,10 @@ In order to capture data that has been updated after creation, please run a peri | |||
|
|
|||
| The Orb connector should not run into Orb API limitations under normal usage. Please [create an issue](https://github.com/airbytehq/airbyte/issues) if you see any rate limit issues that are not automatically retried successfully. | |||
|
|
|||
| :::warning | |||
| The `credit_ledger_entries` stream will now include `events` data. This upgrade uses the `created_at` timestamps from the `credits` to establish a 30-day timeframe, with the earliest `created_at` as the starting point. This restriction is set by the Orb API. | |||
There was a problem hiding this comment.
Small nit:
events have always been included in credit_ledger_entries. The start/end date and 30 day limit is new, though.
alex-gron
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
credit_ledger_entriesprevious version was building request with larger than 30 days. As the Orb API throws errors for these request:Now the connector will create a fixed-window of 30 days based on the
created_atfield inside thecredit_ledger_entryrecord, our best shot to get data from the event.I was able to run a mock test using a single customer and also I added more information whatever the code fails now giving better idea what need to be improved.