Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update source-exchange-rates connector #3566

Merged
merged 7 commits into from
May 26, 2021
Merged

Update source-exchange-rates connector #3566

merged 7 commits into from
May 26, 2021

Conversation

Zirochkaa
Copy link
Contributor

@Zirochkaa Zirochkaa commented May 24, 2021 •
edited
Loading

Since old API (https://api.ratesapi.io/) is gone we are using a new one - http://api.exchangeratesapi.io/.
Update code to support this new API.

What

Closes #3541 issue.

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

┆Issue is synchronized with this Asana task by Unito

@Zirochkaa
Update source-exchange-rates connector
b30582a 
Since old API (https://api.ratesapi.io/) is gone we are using a new one - `http://api.exchangeratesapi.io/`.
Update code to support this new API.
@Zirochkaa Zirochkaa self-assigned this May 24, 2021
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented May 24, 2021 •
edited by github-actions bot
Loading

/test connector=source-exchange-rates

🕑 source-exchange-rates https://github.com/airbytehq/airbyte/actions/runs/872137865
❌ source-exchange-rates https://github.com/airbytehq/airbyte/actions/runs/872137865

@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented May 24, 2021 •
edited by github-actions bot
Loading

/test connector=source-exchange-rates

🕑 source-exchange-rates https://github.com/airbytehq/airbyte/actions/runs/872269063
✅ source-exchange-rates https://github.com/airbytehq/airbyte/actions/runs/872269063

keu
keu approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@keu keu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, otherwise looks good to me

sherifnada
sherifnada approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double check it's being used in the source definitions yaml file? Also do a minor version bump for this one

@Zirochkaa
Copy link
Contributor Author

Can you double check it's being used in the source definitions yaml file? Also do a minor version bump for this one

source-exchange-rates is not in the source_definitions.yaml file, only source-exchangeratesapi-singer, so I'll add it there.

Zirochkaa added 4 commits May 25, 2021 19:17
@Zirochkaa
Merge branch 'master' of github.com:airbytehq/airbyte into oleh/3541-…
194ff7f 
…exchange-api-not-working
@Zirochkaa
Make base parameter from config.json optional
636a1f7 
Update docs with info about how to get an API Access Key.
@Zirochkaa
Update connector version to 0.2.0
74dae8a 
Add `CHANGELOG.md` file.
Use `airbyte/source-exchange-rates` instead of `source-exchangeratesapi-singer`.
Remove `source-exchangeratesapi-singer` from `source_definitions.yaml` and `STANDARD_SOURCE_DEFINITION/` folder.
@Zirochkaa
Merge branch 'master' of github.com:airbytehq/airbyte into oleh/3541-…
efb46cb 
…exchange-api-not-working
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented May 26, 2021 •
edited by github-actions bot
Loading

/test connector=source-exchange-rates

🕑 source-exchange-rates https://github.com/airbytehq/airbyte/actions/runs/878624780
✅ source-exchange-rates https://github.com/airbytehq/airbyte/actions/runs/878624780

@Zirochkaa Zirochkaa requested a review from keu May 26, 2021 13:16
@Zirochkaa Zirochkaa requested a review from sherifnada May 26, 2021 14:02
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented May 26, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-exchange-rates

🕑 connectors/source-exchange-rates https://github.com/airbytehq/airbyte/actions/runs/879614381
✅ connectors/source-exchange-rates https://github.com/airbytehq/airbyte/actions/runs/879614381

@Zirochkaa Zirochkaa merged commit 5aa0364 into master May 26, 2021
@Zirochkaa Zirochkaa deleted the oleh/3541-exchange-api-not-working branch May 26, 2021 18:59
jrhizor
jrhizor reviewed May 26, 2021
View reviewed changes
airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -3,11 +3,12 @@
dockerRepository: airbyte/source-asana
dockerImageTag: 0.1.0
documentationUrl: https://hub.docker.com/r/airbyte/source-asana
- sourceDefinitionId: 9fed261d-d107-47fd-8c8b-323023db6e20
icon: asana.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't have been re-added here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, sorry.

@marcosmarxm marcosmarxm mentioned this pull request May 30, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor left review comments

@keu keu keu approved these changes

@sherifnada sherifnada sherifnada approved these changes

@yevhenii-ldv yevhenii-ldv Awaiting requested review from yevhenii-ldv

@vitaliizazmic vitaliizazmic Awaiting requested review from vitaliizazmic

Assignees

@Zirochkaa Zirochkaa

Labels
connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exchange API connector not working
5 participants
@Zirochkaa @jrhizor @keu @sherifnada @karinakuz