Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source S3: revert rollback to 4.4.1 #35055

Merged
merged 7 commits into from
Feb 16, 2024
Merged

Source S3: revert rollback to 4.4.1 #35055

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c620c24
Source S3: revert rollback to 4.4.1
clnoll Feb 9, 2024
854daee
Remove pin
clnoll Feb 12, 2024
6b21439
Temporarily turn off concurrency for a cleaner revert
clnoll Feb 15, 2024
2983c93
Bump CDK version
clnoll Feb 15, 2024
364bd0d
Update airbyte-integrations/connectors/source-s3/pyproject.toml
clnoll Feb 16, 2024
1275ec0
Bump version in pyproject.toml
clnoll Feb 16, 2024
4604e41
redo poetry lock
clnoll Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions airbyte-integrations/connectors/source-s3/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
connectorSubtype: file
connectorType: source
definitionId: 69589781-7828-43c5-9f63-8925b1c1ccc2
dockerImageTag: 4.5.3
dockerImageTag: 4.5.4
dockerRepository: airbyte/source-s3
documentationUrl: https://docs.airbyte.com/integrations/sources/s3
githubIssueLabel: source-s3
Expand All @@ -23,7 +23,6 @@ data:
packageName: airbyte-source-s3
registries:
cloud:
dockerImageTag: 4.4.1
enabled: true
oss:
enabled: true
Expand Down
30 changes: 15 additions & 15 deletions airbyte-integrations/connectors/source-s3/poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-s3/pyproject.toml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump the connector version in this file too. It's gonna be validated by CI once #35322 is mainlined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done.

Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ source-s3 = "source_s3.run:run"

[tool.poetry.dependencies.airbyte-cdk]
extras = [ "file-based",]
version = "==0.61.0"
version = "==0.63.1"

[tool.poetry.dependencies.smart-open]
extras = [ "s3",]
Expand Down
2 changes: 0 additions & 2 deletions airbyte-integrations/connectors/source-s3/source_s3/v4/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@


class SourceS3(FileBasedSource):
_concurrency_level = DEFAULT_CONCURRENCY

@classmethod
def read_config(cls, config_path: str) -> Mapping[str, Any]:
"""
Expand Down
3 changes: 2 additions & 1 deletion docs/integrations/sources/s3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,8 @@ To perform the text extraction from PDF and Docx files, the connector uses the [

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:----------------------------------------------------------------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------|
| 4.5.3 | 2024-02-12 | [35164](https://github.com/airbytehq/airbyte/pull/35164) | Manage dependencies with Poetry. |
| 4.5.4 | 2024-02-15 | [35055](https://github.com/airbytehq/airbyte/pull/35055) | Temporarily revert concurrency |
| 4.5.3 | 2024-02-12 | [35164](https://github.com/airbytehq/airbyte/pull/35164) | Manage dependencies with Poetry. |
| 4.5.2 | 2024-02-06 | [34930](https://github.com/airbytehq/airbyte/pull/34930) | Bump CDK version to fix issue when SyncMode is missing from catalog |
| 4.5.1 | 2024-02-02 | [31701](https://github.com/airbytehq/airbyte/pull/31701) | Add `region` support |
| 4.5.0 | 2024-02-01 | [34591](https://github.com/airbytehq/airbyte/pull/34591) | Run full refresh syncs concurrently |
Expand Down
Loading