Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Facebook Marketing: Add statuses filters #32449

Merged
merged 24 commits into from
Feb 20, 2024
Merged

🐛 Source Facebook Marketing: Add statuses filters #32449

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
e67f0cd
all except integration tests
iSINUS Nov 10, 2023
4fc52c2
fix tests
iSINUS Nov 11, 2023
6f2bb68
update docs and unit test
iSINUS Nov 11, 2023
62371e7
Merge branch 'master' into sivanou/source-facebook-marketing-statuses
iSINUS Dec 8, 2023
34b1078
add default ALL status
iSINUS Jan 8, 2024
80e76c0
Merge branch 'master' into sivanou/source-facebook-marketing-statuses
iSINUS Jan 8, 2024
f497a25
Merge branch 'master' into sivanou/source-facebook-marketing-statuses
iSINUS Jan 9, 2024
d04f8cb
Merge branch 'master' into sivanou/source-facebook-marketing-statuses
iSINUS Jan 11, 2024
1fc2814
fix version
iSINUS Jan 11, 2024
6a64dfe
Merge branch 'master' into sivanou/source-facebook-marketing-statuses
iSINUS Jan 12, 2024
6b73da7
Merge branch 'master' into sivanou/source-facebook-marketing-statuses
iSINUS Jan 15, 2024
4f584ac
Update facebook-marketing.md
iSINUS Jan 15, 2024
833c3f1
Merge branch 'master' into sivanou/source-facebook-marketing-statuses
iSINUS Jan 15, 2024
d6e0dc4
Merge branch 'master' into sivanou/source-facebook-marketing-statuses
iSINUS Jan 19, 2024
35f69ee
Merge branch 'master' into sivanou/source-facebook-marketing-statuses
iSINUS Jan 26, 2024
9bf86c8
Merge branch 'master' into sivanou/source-facebook-marketing-statuses
iSINUS Feb 1, 2024
7b15d19
Update spec.py
iSINUS Feb 2, 2024
d3f6b05
Merge branch 'master' into sivanou/source-facebook-marketing-statuses
iSINUS Feb 2, 2024
baafe0f
Merge branch 'master' into sivanou/source-facebook-marketing-statuses
iSINUS Feb 8, 2024
a4f5e93
correct test spec
iSINUS Feb 8, 2024
b3057a8
Add state migration and fix errors
tolik0 Feb 19, 2024
13ea3fc
Merge remote-tracking branch 'origin/master' into sivanou/source-face…
tolik0 Feb 20, 2024
0030acc
Delete wrong file from merge conflict
tolik0 Feb 20, 2024
6921ec0
Update pyproject.toml
tolik0 Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions airbyte-integrations/connectors/source-facebook-marketing/integration_tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,27 @@ def config_with_wrong_account_fixture(config):


@pytest.fixture(scope="session", name="config_with_include_deleted")
def config_with_include_deleted_fixture(config):
new_config = {**config, "include_deleted": True}
def config_with_include_deleted(config):
new_config = {
**config,
"campaign_statuses": ["ACTIVE", "ARCHIVED", "DELETED", "IN_PROCESS", "PAUSED", "WITH_ISSUES"],
"adset_statuses": ["ACTIVE", "ARCHIVED", "CAMPAIGN_PAUSED", "DELETED", "IN_PROCESS", "PAUSED", "WITH_ISSUES"],
"ad_statuses": [
"ACTIVE",
"ADSET_PAUSED",
"ARCHIVED",
"CAMPAIGN_PAUSED",
"DELETED",
"DISAPPROVED",
"IN_PROCESS",
"PAUSED",
"PENDING_BILLING_INFO",
"PENDING_REVIEW",
"PREAPPROVED",
"WITH_ISSUES",
],
"adcreative_statuses": ["ACTIVE", "DELETED", "IN_PROCESS", "WITH_ISSUES"],
}
new_config.pop("_limit", None)
new_config.pop("end_date", None)
return new_config
67 changes: 36 additions & 31 deletions ...yte-integrations/connectors/source-facebook-marketing/integration_tests/future_state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"stream": {
"stream_state": {
"event_time": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "activities"
Expand All @@ -16,7 +16,9 @@
"stream": {
"stream_state": {
"updated_time": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": [
"ARCHIVED"
]
},
"stream_descriptor": {
"name": "campaigns"
Expand All @@ -28,7 +30,7 @@
"stream": {
"stream_state": {
"updated_time": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "images"
Expand All @@ -40,7 +42,7 @@
"stream": {
"stream_state": {
"updated_time": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "videos"
Expand All @@ -52,7 +54,7 @@
"stream": {
"stream_state": {
"updated_time": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ad_creatives"
Expand All @@ -64,7 +66,9 @@
"stream": {
"stream_state": {
"updated_time": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": [
"ARCHIVED"
]
},
"stream_descriptor": {
"name": "ad_sets"
Expand All @@ -76,7 +80,9 @@
"stream": {
"stream_state": {
"updated_time": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": [
"ARCHIVED"
]
},
"stream_descriptor": {
"name": "ads"
Expand All @@ -88,7 +94,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights"
Expand All @@ -100,7 +106,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_age_and_gender"
Expand All @@ -112,7 +118,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_country"
Expand All @@ -124,7 +130,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_dma"
Expand All @@ -136,7 +142,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_platform_and_device"
Expand All @@ -148,7 +154,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_region"
Expand All @@ -160,7 +166,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_action_type"
Expand All @@ -172,20 +178,19 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "custommy_custom_insights"
}
}
},

{
"type": "STREAM",
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_action_carousel_card"
Expand All @@ -197,7 +202,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_action_conversion_device"
Expand All @@ -209,7 +214,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_action_product_id"
Expand All @@ -221,7 +226,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_action_reaction"
Expand All @@ -233,7 +238,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_action_video_sound"
Expand All @@ -245,7 +250,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_action_video_type"
Expand All @@ -257,7 +262,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_delivery_device"
Expand All @@ -269,7 +274,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_delivery_platform"
Expand All @@ -281,7 +286,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_delivery_platform_and_device_platform"
Expand All @@ -293,7 +298,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_demographics_age"
Expand All @@ -305,7 +310,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_demographics_country"
Expand All @@ -317,7 +322,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_demographics_dma_region"
Expand All @@ -329,7 +334,7 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "ads_insights_demographics_gender"
Expand All @@ -341,11 +346,11 @@
"stream": {
"stream_state": {
"date_start": "2121-07-25T13:34:26Z",
"include_deleted": true
"filter_statuses": []
},
"stream_descriptor": {
"name": "customcustom_insight_stream"
}
}
}
]
]
5 changes: 2 additions & 3 deletions ...e-integrations/connectors/source-facebook-marketing/integration_tests/invalid_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"start_date": "2023-04-01T00:00:00Z",
"account_id": "account",
"access_token": "wrong_token",
"include_deleted": true
}
"access_token": "wrong_token"
}
Loading