Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle: fix repo wide behaviour #30607

Merged
merged 34 commits into from
Sep 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
fd07a1e
gradle: remove dead pmd tasks
Sep 19, 2023
acb46c2
gradle: make integrationTest more like test
Sep 19, 2023
121f715
gradle: fix integration+performanceTest dependencies
Sep 19, 2023
bc3cfcf
gradle: remove python connectors from gradle, if supported by airbyte-ci
Sep 19, 2023
2592656
gradle: get compileJava to succeed
Sep 19, 2023
a8a7fbc
gradle: get compileTestJava to succeed
Sep 19, 2023
dc9dbed
gradle: get compileIntegrationTestJavaJava to pass
Sep 19, 2023
bdde958
gradle: silence useless gradle warning
Sep 19, 2023
4eb1e9d
gradle: get check -x test -x unitTests to pass
Sep 19, 2023
e017d6b
gradle: begin retiring SUB_BUILD
Sep 19, 2023
82bccad
gradle: 'repositories' cleanup
Sep 20, 2023
ed66d67
gradle: clean up included projects in settings.gradle
Sep 20, 2023
4ea500f
gradle: get assemble to work
Sep 20, 2023
dabc804
gradle: speed up 'tasks' task
Sep 20, 2023
02d5090
gradle: per-project format tasks to check or apply formatting rules
Sep 20, 2023
2a96140
gradle: disable flake checks in 'check'
Sep 20, 2023
2d0ff3a
gradle: disable S3 cache outside of github or EC2 worker
Sep 26, 2023
f2a96d0
gradle: add skipSlowTests property
Sep 20, 2023
b01ff84
gradleize destination-duckdb to fix missing dependencies
Sep 20, 2023
84c4c68
gradle: get 'check -DskipSlowTests=true' to pass
Sep 20, 2023
212c03b
.github: do gradle check in CI, revamp gradle.yml
Sep 20, 2023
b20dd88
Merge branch 'master' into fix-repo-wide-gradle-behaviour
Sep 27, 2023
0de37a0
gradle: silence noise about build cache absence
Sep 27, 2023
699900f
gradle: fix generateSourceTestDocs task
Sep 27, 2023
b25dd97
gradle: get sources to compile after CDK merge
Sep 28, 2023
b3b83b4
apply gradle format
Sep 28, 2023
d1a773d
gradle: fix skipSlowTests property
Sep 28, 2023
64637a7
gradle: set useLocalCdk = true for a couple of unmaintained connectors
Sep 28, 2023
fffae27
gradle: better clean
Sep 28, 2023
ee202d6
airbyte-ci: fix unit testfollowing CDK merge
Sep 28, 2023
c449d7d
gradle: bump node and npm version numbers for spotlessStyling
Sep 28, 2023
16e6125
Revert "apply gradle format"
Sep 28, 2023
7c7b047
Merge branch 'master' into fix-repo-wide-gradle-behaviour
Sep 28, 2023
9d4d8d6
apply gradle format
Sep 28, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
47 changes: 0 additions & 47 deletions .github/actions/cache-build-artifacts/action.yml

This file was deleted.

16 changes: 8 additions & 8 deletions .github/actions/runner-prepare-for-build/action.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
name: 'Prepare Runner for Building'
description: 'Prepare Runner for Building project'
name: "Prepare Runner for Building"
description: "Prepare Runner for Building project"
inputs:
install_java:
description: ''
description: ""
required: false
default: 'true'
default: "true"
install_node:
description: ''
description: ""
required: false
default: 'true'
default: "true"
install_python:
description: ''
description: ""
required: false
default: 'true'
default: "true"
runs:
using: "composite"
steps:
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/connector-performance-command.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,10 @@ jobs:
if: steps.regex.outputs.first_match != github.event.inputs.connector
run: echo "The connector provided has an invalid format!" && exit 1
- name: Filter supported connectors
if: "${{ github.event.inputs.connector != 'connectors/source-postgres' &&
github.event.inputs.connector != 'connectors/source-mysql' &&
github.event.inputs.connector != 'connectors/destination-snowflake' }}"
if:
"${{ github.event.inputs.connector != 'connectors/source-postgres' &&
github.event.inputs.connector != 'connectors/source-mysql' &&
github.event.inputs.connector != 'connectors/destination-snowflake' }}"
run: echo "Only connectors/source-postgres, source-mysql and destination-snowflake currently supported by harness" && exit 1
- name: Checkout Airbyte
uses: actions/checkout@v3
Expand Down Expand Up @@ -181,7 +182,7 @@ jobs:
- name: Link comment to workflow run
uses: peter-evans/create-or-update-comment@v2
with:
reactions: '+1'
reactions: "+1"
comment-id: ${{ github.event.inputs.comment-id }}
body: |
## Performance test Result:
Expand Down
11 changes: 10 additions & 1 deletion .github/workflows/connector_checklist_require.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
name: Require Connector Checklist
on:
pull_request:
types: [opened, edited, synchronize, labeled, unlabeled, reopened, ready_for_review]
types:
[
opened,
edited,
synchronize,
labeled,
unlabeled,
reopened,
ready_for_review,
]
paths:
- "airbyte-integrations/connectors/source-**"
- "airbyte-integrations/connectors/destination-**"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,3 @@ jobs:
status: ${{ steps.get-mandatory-reviewers.outputs.MANDATORY_REVIEWERS }}
token: ${{ secrets.OCTAVIA_4_ROOT_ACCESS }}
requirements-file: .github/connector_org_review_requirements.yaml

18 changes: 0 additions & 18 deletions .github/workflows/connectors_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,6 @@ jobs:
if: github.event_name == 'workflow_dispatch'
run: echo "branch=${GITHUB_REF#refs/heads/}" >> $GITHUB_OUTPUT
id: extract_branch
# - name: Format connectors [PULL REQUESTS]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

# if: github.event_name == 'pull_request'
# uses: ./.github/actions/run-dagger-pipeline
# with:
# context: "pull_request"
# docker_hub_password: ${{ secrets.DOCKER_HUB_PASSWORD }}
# docker_hub_username: ${{ secrets.DOCKER_HUB_USERNAME }}
# gcp_gsm_credentials: ${{ secrets.GCP_GSM_CREDENTIALS }}
# git_branch: ${{ github.head_ref }}
# git_revision: ${{ github.sha }}
# github_token: ${{ secrets.GH_PAT_MAINTENANCE_OCTAVIA }}
# subcommand: "connectors --modified format"
- name: Fetch last commit id from remote branch [PULL REQUESTS]
if: github.event_name == 'pull_request'
id: fetch_last_commit_id_pr
Expand All @@ -63,12 +51,6 @@ jobs:
if: github.event_name == 'workflow_dispatch'
id: fetch_last_commit_id_wd
run: echo "commit_id=$(git rev-parse origin/${{ steps.extract_branch.outputs.branch }})" >> $GITHUB_OUTPUT
- name: Pull formatting changes [PULL REQUESTS]
if: github.event_name == 'pull_request'
uses: actions/checkout@v3
with:
repository: ${{ github.event.inputs.repo }}
ref: ${{ steps.fetch_last_commit_id_pr.outputs.commit_id }}
- name: Test connectors [WORKFLOW DISPATCH]
if: github.event_name == 'workflow_dispatch'
uses: ./.github/actions/run-dagger-pipeline
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/connectors_weekly_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ jobs:
gcp_gsm_credentials: ${{ secrets.GCP_GSM_CREDENTIALS }}
git_branch: ${{ steps.extract_branch.outputs.branch }}
github_token: ${{ secrets.GITHUB_TOKEN }}
subcommand: "--show-dagger-logs connectors ${{ inputs.test-connectors-options || '--concurrency=3 --metadata-query=\"(data.ab_internal.ql > 100) & (data.ab_internal.sl < 200)\"' }} test"
subcommand: '--show-dagger-logs connectors ${{ inputs.test-connectors-options || ''--concurrency=3 --metadata-query="(data.ab_internal.ql > 100) & (data.ab_internal.sl < 200)"'' }} test'
6 changes: 3 additions & 3 deletions .github/workflows/doc-link-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ name: Check for broken links in docs
on:
workflow_dispatch:
schedule:
- cron: '0 18 * * *'
- cron: "0 18 * * *"

jobs:
markdown-link-check:
Expand All @@ -17,8 +17,8 @@ jobs:
# check all files on master
- uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
use-quiet-mode: 'yes'
check-modified-files-only: 'no'
use-quiet-mode: "yes"
check-modified-files-only: "no"
config-file: .github/workflows/doc-link-check.json

# posts to #_doc_link_checker
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,4 +98,3 @@ jobs:
{\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\"<@${{ steps.match-github-to-slack-user.outputs.slack_user_ids }}> \n\"}},
{\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\" :octavia-shocked: <https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}|View Action Run> :octavia-shocked: \n\"}},
{\"type\":\"divider\"}]}

Loading