-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Action: Add format.yml workflow #30604
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Originally I was worried that having this workflow run concurrently to that in gradle.yml would lead to all kinds of problems due to this pushing a commit and therefore invalidating the other, but now I realize that gradle.yml has routinely been failing and that that doesn't seem to be causing any trouble.
I had this same concern. So far it seeems fine. I think its mostly due to that github doesnt trigger further actions on automated commits. |
Just waiting for some green checks to get this in. If im wrong Im sure I will find out very quickly |
Ran into an issue where
Very known issue: https://github.com/stefanzweifel/git-auto-commit-action#commits-made-by-this-action-do-not-trigger-new-workflow-runs Solution
Thought:
|
Still plan on merging once gradle related tests pass. I cancelled Connector tests as they are redundant. |
|
|
Step | Result |
---|---|
Connector package install | ✅ |
Build destination-duckdb docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate airbyte-integrations/connectors/destination-duckdb/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ❌ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-duckdb test
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-apify-dataset docker image for platform linux/x86_64 | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate airbyte-integrations/connectors/source-apify-dataset/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-apify-dataset test
This all makes sense, SGTM. |
/approve-and-merge reason="format changes" |
Co-authored-by: bnchrch <[email protected]> Co-authored-by: octavia-approvington <[email protected]>
Problem(s)
Short term solution
closes #27675
Long terms solution
Theres enough going on here that I want to propose a longer change
Working on a document explaining that now: https://docs.google.com/document/d/1X8KVmomXT5EwiNuwyvO5oQGMTMrZbt1nyBxWsSpDEo8/edit