Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle: fix airbyteDocker task inputs #30187

Merged
merged 9 commits into from
Sep 7, 2023

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Sep 6, 2023

This PR follows up on #30060 and this time the changes are mostly centered on the airbyte-docker plugin:

  • its tasks no longer declare the whole project directory as an input, instead it uses the already-existing .dockerignore files;
  • its tasks are now a dependency of the assemble step instead of build, because building a docker image shouldn't depend on unit tests passing (the main reason being, the docker image may itself be a transitive dependency);
  • its tasks now depend on generate;
  • as far as airbyte-python in concerned, airbyteDocker would depend on flake checks and the like, which in turn depended on an expensive local venv setup; these checks still exist but have been moved from assemble to check, so that for a python project assemble really only consists of generate followed by airbyteDocker.

This PR also bumps to the latest gradle major version. This has been useful to track bad task inputs because the latest gradle is much more strict about these things.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-clickhouse test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 08mn29s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-clickhouse docker image for platform linux/x86_64
Build airbyte/normalization-clickhouse:dev
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-clickhouse/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-clickhouse test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-teradata test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 09mn15s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-teradata docker image for platform linux/x86_64
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-teradata/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-teradata test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

source-oracle test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 06mn46s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-oracle docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-oracle/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-oracle test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-exasol test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 10mn51s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-exasol docker image for platform linux/x86_64
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-exasol/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-exasol test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

source-oracle-strict-encrypt test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 21mn46s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-oracle-strict-encrypt docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-oracle-strict-encrypt/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-oracle-strict-encrypt test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

source-postgres-strict-encrypt test report (commit 86b71643d8) - ✅

⏲️ Total pipeline duration: 13mn56s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-postgres-strict-encrypt docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-postgres-strict-encrypt/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres-strict-encrypt test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-azure-blob-storage test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 09mn31s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-azure-blob-storage docker image for platform linux/x86_64
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-azure-blob-storage/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-azure-blob-storage test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

source-postgres test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 28mn54s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-postgres docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-postgres/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-gcs test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 10mn21s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-gcs docker image for platform linux/x86_64
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-gcs/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-gcs test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-mongodb test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 06mn28s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-mongodb docker image for platform linux/x86_64
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-mongodb/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-mongodb test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-doris test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 06mn26s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-doris docker image for platform linux/x86_64
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-doris/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-doris test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-starburst-galaxy test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 20mn04s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-starburst-galaxy docker image for platform linux/x86_64
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-starburst-galaxy/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-starburst-galaxy test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-pubsub test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 06mn20s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-pubsub docker image for platform linux/x86_64
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-pubsub/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-pubsub test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-s3-glue test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 09mn42s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-s3-glue docker image for platform linux/x86_64
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-s3-glue/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-s3-glue test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-csv test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 03mn37s

Step Result
Java Connector Unit Tests
Build connector tar
Validate airbyte-integrations/connectors/destination-csv/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-csv test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

source-e2e-test test report (commit 86b71643d8) - ✅

⏲️ Total pipeline duration: 07mn45s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-e2e-test docker image for platform linux/x86_64
Java Connector Integration Tests
Validate airbyte-integrations/connectors/source-e2e-test/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-e2e-test test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-redis test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 06mn37s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-redis docker image for platform linux/x86_64
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-redis/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-redis test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-scylla test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 06mn37s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-scylla docker image for platform linux/x86_64
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-scylla/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-scylla test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

source-e2e-test-cloud test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 07mn41s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-e2e-test-cloud docker image for platform linux/x86_64
Java Connector Integration Tests
Validate airbyte-integrations/connectors/source-e2e-test-cloud/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-e2e-test-cloud test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-vertica test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 05mn07s

Step Result
Java Connector Unit Tests
Build connector tar
Validate airbyte-integrations/connectors/destination-vertica/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-vertica test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

destination-mariadb-columnstore test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 10mn52s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-mariadb-columnstore docker image for platform linux/x86_64
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-mariadb-columnstore/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-mariadb-columnstore test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

source-alloydb test report (commit 86b71643d8) - ❌

⏲️ Total pipeline duration: 07mn53s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-alloydb docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-alloydb/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-alloydb test

@aaronsteers
Copy link
Collaborator

@postamar - This looks great. One thing I noticed though was that the MSSQL source seems to be failing to run tests in the above results: #30187 (comment)

It might be that this one was already broken, but might be worth double-checking that it isn’t breaking from the Gradle-related (docker dependency-related) changes.

@postamar
Copy link
Contributor Author

postamar commented Sep 6, 2023

I checked that source-mssql CI run and it's failing due to ci_credentials source-mssql write-to-storage logging something as CRITICAL. It seems unrelated to my changes. Thanks for noticing!

Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a code read-through and I don’t see any issues. Thanks for tackling this. 🚀

dependsOn project(':tools:code-generator').tasks.named('airbyteDocker')
dependsOn project(':tools:code-generator').tasks.named('assemble')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@postamar
Copy link
Contributor Author

postamar commented Sep 7, 2023

Thanks for the reviews!

@postamar
Copy link
Contributor Author

postamar commented Sep 7, 2023

/approve-and-merge reason="unavoidable force-merge"

@postamar postamar merged commit ef2849e into master Sep 7, 2023
@postamar postamar deleted the postamar/fix-airbyte-docker-inputs branch September 7, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/destination/azure-blob-storage connectors/destination/bigquery connectors/destination/bigquery-denormalized connectors/destination/cassandra connectors/destination/clickhouse connectors/destination/clickhouse-strict-encrypt connectors/destination/csv connectors/destination/databricks connectors/destination/dev-null connectors/destination/doris connectors/destination/dynamodb connectors/destination/e2e-test connectors/destination/elasticsearch connectors/destination/elasticsearch-strict-encryp connectors/destination/exasol connectors/destination/gcs connectors/destination/iceberg connectors/destination/kafka connectors/destination/keen connectors/destination/kinesis connectors/destination/local-json connectors/destination/mariadb-columnstore connectors/destination/mongodb connectors/destination/mongodb-strict-encrypt connectors/destination/mqtt connectors/destination/mssql connectors/destination/mssql-strict-encrypt connectors/destination/mysql connectors/destination/mysql-strict-encrypt connectors/destination/oracle connectors/destination/oracle-strict-encrypt connectors/destination/postgres connectors/destination/postgres-strict-encrypt connectors/destination/pubsub connectors/destination/pulsar connectors/destination/r2 connectors/destination/redis connectors/destination/redpanda connectors/destination/redshift connectors/destination/rockset connectors/destination/s3-glue connectors/destination/s3 connectors/destination/scylla connectors/destination/selectdb connectors/destination/snowflake connectors/destination/starburst-galaxy connectors/destination/teradata connectors/destination/tidb connectors/destination/vertica connectors/destination/yugabytedb connectors/source/alloydb connectors/source/alloydb-strict-encrypt connectors/source/clickhouse connectors/source/clickhouse-strict-encrypt connectors/source/db2 connectors/source/e2e-test connectors/source/e2e-test-cloud connectors/source/elasticsearch connectors/source/jdbc connectors/source/mongodb-strict-encrypt connectors/source/mongodb-v2 connectors/source/mssql connectors/source/mssql-strict-encrypt connectors/source/mysql connectors/source/mysql-strict-encrypt connectors/source/oracle connectors/source/oracle-strict-encrypt connectors/source/postgres connectors/source/postgres-strict-encrypt connectors/source/redshift connectors/source/relational-db connectors/source/sftp connectors/source/snowflake normalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants