-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination Azure Blob Storage - File Extensions added for the output files #27701
Destination Azure Blob Storage - File Extensions added for the output files #27701
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
…into destination-azure-blob-storage
Sorry for the long delay in getting this reviewed and merged. Our team is currently finishing the August Hackathon review contributions over the next two weeks, and after that, we will return to the community backlog. |
ping @marcosmarxm |
Hello @richa-rochna thanks for the contribution and sorry for the lack of updates. |
@marcosmarxm any update on this? |
Hello @richa-rochna I needed to make some changes to your branch and I'll merge the contribution #38061 |
… files #27701 (#38061) Co-authored-by: richa-rochna <[email protected]> Co-authored-by: Richa Rochna <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]>
What
Currently, the output is stored as a file with no extension. The solution will save the output with file extensions.
How
Added an optional field file_extension for csv format, enabling this field will allow the output to be stored with file extensions.
Recommended reading order
spec.json
y.python
🚨 User Impact 🚨
No breaking changes. An optional field is added.
For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.
If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Actions
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.0.0.1
Dockerfile
has version0.0.1
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog with an entry for the initial version. See changelog exampledocs/integrations/README.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes