Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Amazon Seller Partner: add FBA Reimbursement Report stream #23605

Merged
merged 16 commits into from
Apr 27, 2023

Conversation

Shishir-rmv
Copy link
Contributor

@Shishir-rmv Shishir-rmv commented Mar 1, 2023

What

Add capability to pull FBA Reimbursement data

How

Add new stream GET_FBA_REIMBURSEMENTS_DATA to pull reimbursement data for Amazon seller partner

Recommended reading order

  1. airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.py
  2. airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py
  3. airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/schemas/GET_FBA_REIMBURSEMENTS_DATA.json
  4. airbyte-integrations/connectors/source-amazon-seller-partner/integration_tests/configured_catalog_get_fba_reimbursements_data.json
  5. airbyte-integrations/connectors/source-amazon-seller-partner/acceptance-test-config.yml

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

  • Not a breaking change

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit tests
❯ python -m pytest unit_tests

Test session starts (platform: darwin, Python 3.9.6, pytest 6.2.5, pytest-sugar 0.9.6)
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/.hypothesis/examples')
rootdir: /Users/sverma/code/github.com/Shishir-rmv/airbyte, configfile: pytest.ini
plugins: hypothesis-6.54.6, requests-mock-1.9.3, mock-3.6.1, sugar-0.9.6, timeout-1.4.2, cov-3.0.0
collecting ...
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_finance_streams.py::test_finance_stream_next_token ✓                                                                                                                1% ▏         {"type": "LOG", "log": {"level": "INFO", "message": "start date used: 2022-05-25T00:00:00Z"}}
{"type": "LOG", "log": {"level": "INFO", "message": "start date used: 2022-02-01T00:00:00Z"}}

 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_finance_streams.py::test_financial_event_groups_stream_request_params ✓                                                                                             2% ▎
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_finance_streams.py::test_financial_event_groups_stream_parse_response ✓                                                                                             3% ▍         {"type": "LOG", "log": {"level": "INFO", "message": "start date used: 2022-05-25T00:00:00Z"}}
{"type": "LOG", "log": {"level": "INFO", "message": "start date used: 2022-02-01T00:00:00Z"}}

 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_finance_streams.py::test_financial_events_stream_request_params ✓                                                                                                   4% ▌
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_finance_streams.py::test_financial_events_stream_parse_response ✓                                                                                                   5% ▌
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_reports_streams_rate_limits.py::test_reports_stream_should_retry ✓                                                                                                  6% ▋
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_reports_streams_rate_limits.py::test_reports_stream_send_request ✓                                                                                                  7% ▊         {"type": "LOG", "log": {"level": "INFO", "message": "Backing off _send_request(...) for 5.0s (airbyte_cdk.sources.streams.http.exceptions.DefaultBackoffException: Request URL: None, Response Code: 429, Response Text: )"}}
{"type": "LOG", "log": {"level": "INFO", "message": "Caught retryable error 'Request URL: None, Response Code: 429, Response Text: ' after 1 tries. Waiting 5 seconds then retrying..."}}
{"type": "LOG", "log": {"level": "INFO", "message": "Backing off _send_request(...) for 10.0s (airbyte_cdk.sources.streams.http.exceptions.DefaultBackoffException: Request URL: None, Response Code: 429, Response Text: )"}}
{"type": "LOG", "log": {"level": "INFO", "message": "Caught retryable error 'Request URL: None, Response Code: 429, Response Text: ' after 2 tries. Waiting 10 seconds then retrying..."}}
{"type": "LOG", "log": {"level": "INFO", "message": "Backing off _send_request(...) for 20.0s (airbyte_cdk.sources.streams.http.exceptions.DefaultBackoffException: Request URL: None, Response Code: 429, Response Text: )"}}
{"type": "LOG", "log": {"level": "INFO", "message": "Caught retryable error 'Request URL: None, Response Code: 429, Response Text: ' after 3 tries. Waiting 20 seconds then retrying..."}}
{"type": "LOG", "log": {"level": "INFO", "message": "Backing off _send_request(...) for 40.0s (airbyte_cdk.sources.streams.http.exceptions.DefaultBackoffException: Request URL: None, Response Code: 429, Response Text: )"}}
{"type": "LOG", "log": {"level": "INFO", "message": "Caught retryable error 'Request URL: None, Response Code: 429, Response Text: ' after 4 tries. Waiting 40 seconds then retrying..."}}
{"type": "LOG", "log": {"level": "ERROR", "message": "Giving up _send_request(...) after 5 tries (airbyte_cdk.sources.streams.http.exceptions.DefaultBackoffException: Request URL: None, Response Code: 429, Response Text: )"}}

 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_reports_streams_rate_limits.py::test_reports_stream_send_request_backoff_exception ✓                                                                                9% ▉
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_reports_streams_settlement_report.py::test_stream_slices_method ✓                                                                                                  10% ▉
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_source.py::test_spec ✓                                                                                                                                             11% █▏
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_source.py::test_streams ✓                                                                                                                                          12% █▎
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_source.py::test_stream_with_good_iam_arn_value[arn:aws:iam::123456789098:user/some-user] ✓                                                                         13% █▍
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_source.py::test_stream_with_good_iam_arn_value[arn:aws:iam::123456789098:role/some-role] ✓                                                                         14% █▍
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_source.py::test_stream_with_bad_iam_arn_value ✓                                                                                                                    15% █▌
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2VIGQ35RCS4UG-input_data0-expected_data0] ✓                                                                 16% █▋
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2VIGQ35RCS4UG-input_data1-expected_data1] ✓                                                                 17% █▊
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2VIGQ35RCS4UG-input_data2-expected_data2] ✓                                                                 18% █▊
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2VIGQ35RCS4UG-input_data3-expected_data3] ✓                                                                 19% █▉
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1PA6795UKMFR9-input_data4-expected_data4] ✓                                                                 20% ██
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1PA6795UKMFR9-input_data5-expected_data5] ✓                                                                 21% ██▎
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1PA6795UKMFR9-input_data6-expected_data6] ✓                                                                 22% ██▎
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1PA6795UKMFR9-input_data7-expected_data7] ✓                                                                 23% ██▍
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1C3SOZRARQ6R3-input_data8-expected_data8] ✓                                                                 24% ██▌
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1C3SOZRARQ6R3-input_data9-expected_data9] ✓                                                                 26% ██▋
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1C3SOZRARQ6R3-input_data10-expected_data10] ✓                                                               27% ██▋
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1C3SOZRARQ6R3-input_data11-expected_data11] ✓                                                               28% ██▊
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[ARBP9OOSHTCHU-input_data12-expected_data12] ✓                                                                29% ██▉
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[ARBP9OOSHTCHU-input_data13-expected_data13] ✓                                                                30% ███
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[ARBP9OOSHTCHU-input_data14-expected_data14] ✓                                                                31% ███▏
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[ARBP9OOSHTCHU-input_data15-expected_data15] ✓                                                                32% ███▎
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1RKKUPIHCS9HS-input_data16-expected_data16] ✓                                                               33% ███▍
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1RKKUPIHCS9HS-input_data17-expected_data17] ✓                                                               34% ███▌
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1RKKUPIHCS9HS-input_data18-expected_data18] ✓                                                               35% ███▌
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1RKKUPIHCS9HS-input_data19-expected_data19] ✓                                                               36% ███▋
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A13V1IB3VIYZZH-input_data20-expected_data20] ✓                                                               37% ███▊
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A13V1IB3VIYZZH-input_data21-expected_data21] ✓                                                               38% ███▉
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A13V1IB3VIYZZH-input_data22-expected_data22] ✓                                                               39% ███▉
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A13V1IB3VIYZZH-input_data23-expected_data23] ✓                                                               40% ████▏
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A21TJRUUN4KGV-input_data24-expected_data24] ✓                                                                41% ████▎
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A21TJRUUN4KGV-input_data25-expected_data25] ✓                                                                43% ████▍
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A21TJRUUN4KGV-input_data26-expected_data26] ✓                                                                44% ████▍
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A21TJRUUN4KGV-input_data27-expected_data27] ✓                                                                45% ████▌
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[APJ6JRA9NG5V4-input_data28-expected_data28] ✓                                                                46% ████▋
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[APJ6JRA9NG5V4-input_data29-expected_data29] ✓                                                                47% ████▊
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[APJ6JRA9NG5V4-input_data30-expected_data30] ✓                                                                48% ████▊
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[APJ6JRA9NG5V4-input_data31-expected_data31] ✓                                                                49% ████▉
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1805IZSGTT6HS-input_data32-expected_data32] ✓                                                               50% █████
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1805IZSGTT6HS-input_data33-expected_data33] ✓                                                               51% █████▏
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1805IZSGTT6HS-input_data34-expected_data34] ✓                                                               52% █████▎
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1805IZSGTT6HS-input_data35-expected_data35] ✓                                                               53% █████▍
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A17E79C6D8DWNP-input_data36-expected_data36] ✓                                                               54% █████▌
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A17E79C6D8DWNP-input_data37-expected_data37] ✓                                                               55% █████▌
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A17E79C6D8DWNP-input_data38-expected_data38] ✓                                                               56% █████▋
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A17E79C6D8DWNP-input_data39-expected_data39] ✓                                                               57% █████▊
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2NODRKZP88ZB9-input_data40-expected_data40] ✓                                                               59% █████▉
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2NODRKZP88ZB9-input_data41-expected_data41] ✓                                                               60% █████▉
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2NODRKZP88ZB9-input_data42-expected_data42] ✓                                                               61% ██████▏
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2NODRKZP88ZB9-input_data43-expected_data43] ✓                                                               62% ██████▎
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A33AVAJ2PDY3EV-input_data44-expected_data44] ✓                                                               63% ██████▍
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A33AVAJ2PDY3EV-input_data45-expected_data45] ✓                                                               64% ██████▍
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A33AVAJ2PDY3EV-input_data46-expected_data46] ✓                                                               65% ██████▌
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A33AVAJ2PDY3EV-input_data47-expected_data47] ✓                                                               66% ██████▋
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1F83G8C2ARO7P-input_data48-expected_data48] ✓                                                               67% ██████▊
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1F83G8C2ARO7P-input_data49-expected_data49] ✓                                                               68% ██████▊
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1F83G8C2ARO7P-input_data50-expected_data50] ✓                                                               69% ██████▉
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1F83G8C2ARO7P-input_data51-expected_data51] ✓                                                               70% ███████
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A39IBJ37TRP1C6-input_data52-expected_data52] ✓                                                               71% ███████▎
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A39IBJ37TRP1C6-input_data53-expected_data53] ✓                                                               72% ███████▎
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A39IBJ37TRP1C6-input_data54-expected_data54] ✓                                                               73% ███████▍
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A39IBJ37TRP1C6-input_data55-expected_data55] ✓                                                               74% ███████▌
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1VC38T7YXB528-input_data56-expected_data56] ✓                                                               76% ███████▋
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1VC38T7YXB528-input_data57-expected_data57] ✓                                                               77% ███████▋
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1VC38T7YXB528-input_data58-expected_data58] ✓                                                               78% ███████▊
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1VC38T7YXB528-input_data59-expected_data59] ✓                                                               79% ███████▉
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A19VAU5U5O7RUS-input_data60-expected_data60] ✓                                                               80% ████████
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A19VAU5U5O7RUS-input_data61-expected_data61] ✓                                                               81% ████████▏
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A19VAU5U5O7RUS-input_data62-expected_data62] ✓                                                               82% ████████▎
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A19VAU5U5O7RUS-input_data63-expected_data63] ✓                                                               83% ████████▍
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[ATVPDKIKX0DER-input_data64-expected_data64] ✓                                                                84% ████████▌
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[ATVPDKIKX0DER-input_data65-expected_data65] ✓                                                                85% ████████▌
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[ATVPDKIKX0DER-input_data66-expected_data66] ✓                                                                86% ████████▋
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[ATVPDKIKX0DER-input_data67-expected_data67] ✓                                                                87% ████████▊
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2Q3Y263D00KWC-input_data68-expected_data68] ✓                                                               88% ████████▉
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2Q3Y263D00KWC-input_data69-expected_data69] ✓                                                               89% ████████▉
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2Q3Y263D00KWC-input_data70-expected_data70] ✓                                                               90% █████████▏
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2Q3Y263D00KWC-input_data71-expected_data71] ✓                                                               91% █████████▎
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2EUQ1WTGCTBG2-input_data72-expected_data72] ✓                                                               93% █████████▍
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2EUQ1WTGCTBG2-input_data73-expected_data73] ✓                                                               94% █████████▍
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2EUQ1WTGCTBG2-input_data74-expected_data74] ✓                                                               95% █████████▌
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A2EUQ1WTGCTBG2-input_data75-expected_data75] ✓                                                               96% █████████▋
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1AM78C64UM0Y8-input_data76-expected_data76] ✓                                                               97% █████████▊
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1AM78C64UM0Y8-input_data77-expected_data77] ✓                                                               98% █████████▊
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1AM78C64UM0Y8-input_data78-expected_data78] ✓                                                               99% █████████▉
 airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_transform_function.py::test_transform_seller_feedback[A1AM78C64UM0Y8-input_data79-expected_data79] ✓                                                              100% ██████████
====================================================================================================================== warnings summary =======================================================================================================================
airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_finance_streams.py: 10 warnings
airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_source.py: 4 warnings
  /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/venv/lib/python3.9/site-packages/airbyte_cdk/sources/streams/http/http.py:45: DeprecationWarning: Call to deprecated class NoAuth. (Set `authenticator=None` instead) -- Deprecated since version 0.1.20.
    self._authenticator: HttpAuthenticator = NoAuth()

airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_finance_streams.py: 10 warnings
airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_source.py: 5 warnings
  /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/venv/lib/python3.9/site-packages/deprecated/classic.py:177: DeprecationWarning: Call to deprecated class HttpAuthenticator. (Use requests.auth.AuthBase instead) -- Deprecated since version 0.1.20.
    return old_new1(cls, *args, **kwargs)

airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_source.py::test_streams
  /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py:83: DeprecationWarning: Call to deprecated class Oauth2Authenticator. (Use airbyte_cdk.sources.streams.http.requests_native_auth.Oauth2Authenticator instead) -- Deprecated since version 0.1.20.
    auth = AWSAuthenticator(

-- Docs: https://docs.pytest.org/en/stable/warnings.html

Results (0.50s):
      94 passed
Integration tests
❯ python -m pytest integration_tests -p integration_tests.acceptance
Test session starts (platform: darwin, Python 3.9.6, pytest 6.2.5, pytest-sugar 0.9.6)
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/.hypothesis/examples')
rootdir: /Users/sverma/code/github.com/Shishir-rmv/airbyte, configfile: pytest.ini
plugins: hypothesis-6.54.6, requests-mock-1.9.3, mock-3.6.1, sugar-0.9.6, timeout-1.4.2, cov-3.0.0
collecting ... {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_config_match_spec[inputs0] ✓                                                                                                    3% ▍         {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_match_expected[inputs0] ✓                                                                                                       5% ▋         {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_docker_env[inputs0] ✓                                                                                                           8% ▊         {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_enum_usage[inputs0] ✓                                                                                                          11% █▏        {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_oneof_usage[inputs0] ✓                                                                                                         14% █▍
 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_required[inputs0] ✓                                                                                                            16% █▋
 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_optional[inputs0] ✓                                                                                                            19% █▉
 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_has_secret[inputs0] ✓                                                                                                          22% ██▎
 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_secret_never_in_the_output[inputs0] ✓                                                                                          24% ██▌       {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_secret_is_properly_marked[inputs0] ✓                                                                                           27% ██▊
 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_property_type_is_not_array[inputs0] ✓                                                                                          30% ███
 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_object_not_empty[inputs0] ✓                                                                                                    32% ███▎
 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_array_type[inputs0] ✓                                                                                                          35% ███▌
 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_forbidden_complex_types[inputs0] ✓                                                                                             38% ███▊
 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_date_pattern[inputs0] ✓                                                                                                        41% ████▏
 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_date_format[inputs0] ✓                                                                                                         43% ████▍     {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_defined_refs_exist_in_json_spec_file[inputs0] ✓                                                                                46% ████▋     {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_oauth_flow_parameters[inputs0] ✓                                                                                               49% ████▉     {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_backward_compatibility[inputs0] s                                                                                              51% █████▎    {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestSpec.test_additional_properties_is_true[inputs0] ✓                                                                                       54% █████▌    {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestConnection.test_check[inputs0] ✓                                                                                                         57% █████▋    {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/integration_tests/invalid_config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestConnection.test_check[inputs1] ✓                                                                                                         59% █████▉    {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestDiscovery.test_discover[inputs0] ✓                                                                                                       62% ██████▎   {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestDiscovery.test_defined_cursors_exist_in_schema[inputs0] ✓                                                                                65% ██████▌   {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestDiscovery.test_defined_refs_exist_in_schema[inputs0] ✓                                                                                   68% ██████▊   {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestDiscovery.test_defined_keyword_exist_in_schema[inputs0-allOf] ✓                                                                          70% ███████   {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestDiscovery.test_defined_keyword_exist_in_schema[inputs0-not] ✓                                                                            73% ███████▍  {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestDiscovery.test_primary_keys_exist_in_schema[inputs0] ✓                                                                                   76% ███████▋  {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestDiscovery.test_streams_has_sync_modes[inputs0] ✓                                                                                         78% ███████▉  {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestDiscovery.test_additional_properties_is_true[inputs0] ✓                                                                                  81% ████████▎ {"type": "LOG", "log": {"level": "INFO", "message": "Using /Users/sverma/code/github.com/Shishir-rmv/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner/secrets/config.json as configuration. It is the most recent version."}}

 airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py::TestDiscovery.test_backward_compatibility[inputs0] ✓                                                                                         84% ████████▍

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 1, 2023
@sajarin
Copy link
Contributor

sajarin commented Apr 17, 2023

Thanks for the contribution @Shishir-rmv sorry for the long delay in review here.

Can you rebase on master and I'll kick off our CI tests so we can work on getting this merged. Thanks again!

@Shishir-rmv Shishir-rmv requested review from a team as code owners April 21, 2023 11:57
@Shishir-rmv Shishir-rmv requested a review from a team April 21, 2023 11:57
@CLAassistant
Copy link

CLAassistant commented Apr 21, 2023

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added CDK Connector Development Kit normalization and removed area/documentation Improvements or additions to documentation labels Apr 21, 2023
@Shishir-rmv Shishir-rmv changed the base branch from master to arsenlosenko/source-amazon-seller-partner-format-date April 21, 2023 12:10
@Shishir-rmv Shishir-rmv requested a review from a team as a code owner April 21, 2023 12:10
@Shishir-rmv Shishir-rmv changed the base branch from arsenlosenko/source-amazon-seller-partner-format-date to master April 21, 2023 12:10
@Shishir-rmv
Copy link
Contributor Author

@sajarin - Thanks for looking into it. I have rebased the branch, please review and let me know if anything else is required from my side.

@octavia-squidington-iii octavia-squidington-iii added area/documentation Improvements or additions to documentation and removed CDK Connector Development Kit normalization labels Apr 22, 2023
@sajarin sajarin removed request for a team April 24, 2023 17:39
@sajarin
Copy link
Contributor

sajarin commented Apr 24, 2023

/test connector=connectors/source-amazon-seller-partner

🕑 connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/4790400699
❌ connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/4790400699
🐛

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream GET_X...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
============= 1 failed, 38 passed, 1 skipped in 2534.19s (0:42:14) =============

@Shishir-rmv
Copy link
Contributor Author

Hi @sajarin - I see the integration tests are failing. From the error message - Failed: Stream GET_XML_BROWSE_TREE_DATA: All expected records must be produced - it looks like the expected records are not matching with the actuals for GET_XML_BROWSE_TREE_DATA stream. Is there something I could do to help?

@sajarin
Copy link
Contributor

sajarin commented Apr 25, 2023

@Shishir-rmv this is something we have to fix on our end, no action is needed from you at the moment.

@sajarin
Copy link
Contributor

sajarin commented Apr 26, 2023

/test connector=connectors/source-amazon-seller-partner

🕑 connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/4811490002
✅ connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/4811490002
Python tests coverage:

Name                                        Stmts   Miss  Cover
---------------------------------------------------------------
source_amazon_seller_partner/spec.py           23      0   100%
source_amazon_seller_partner/__init__.py        2      0   100%
source_amazon_seller_partner/constants.py      38      1    97%
source_amazon_seller_partner/source.py         51     12    76%
source_amazon_seller_partner/streams.py       573    242    58%
source_amazon_seller_partner/auth.py           61     36    41%
---------------------------------------------------------------
TOTAL                                         748    291    61%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 39 passed, 1 skipped in 2447.90s (0:40:47) ==================

@sajarin
Copy link
Contributor

sajarin commented Apr 26, 2023

/publish connector=connectors/source-amazon-seller-partner run-tests=false

🕑 Publishing the following connectors:
connectors/source-amazon-seller-partner
https://github.com/airbytehq/airbyte/actions/runs/4812032292


Connector Version Did it publish? Were definitions generated?
connectors/source-amazon-seller-partner 1.1.0

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@Shishir-rmv Shishir-rmv requested a review from marcosmarxm April 27, 2023 18:36
@sajarin sajarin enabled auto-merge (squash) April 27, 2023 19:04
@sajarin sajarin disabled auto-merge April 27, 2023 19:04
@sajarin sajarin merged commit 3b3ca60 into airbytehq:master Apr 27, 2023
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
…irbytehq#23605)

* add reimbursements stream

* bump up version to 0.2.33 and update changelog

* add reimbursements stream

* bump up version to 0.2.33 and update changelog

* bump up version and update changelog

* correcting version - incrementing minor version as it adds a new stream to the connector

* set additionalProperties to true in the schema

* updated expected_records.txt

* auto-bump connector version

---------

Co-authored-by: Sajarin <[email protected]>
Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants