-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Amazon Seller Partner: add FBA Reimbursement Report stream #23605
🎉 Source Amazon Seller Partner: add FBA Reimbursement Report stream #23605
Conversation
Thanks for the contribution @Shishir-rmv sorry for the long delay in review here. Can you rebase on master and I'll kick off our CI tests so we can work on getting this merged. Thanks again! |
@sajarin - Thanks for looking into it. I have rebased the branch, please review and let me know if anything else is required from my side. |
…am to the connector
/test connector=connectors/source-amazon-seller-partner
Build FailedTest summary info:
|
Hi @sajarin - I see the integration tests are failing. From the error message - |
@Shishir-rmv this is something we have to fix on our end, no action is needed from you at the moment. |
...-amazon-seller-partner/source_amazon_seller_partner/schemas/GET_FBA_REIMBURSEMENTS_DATA.json
Show resolved
Hide resolved
/test connector=connectors/source-amazon-seller-partner
Build PassedTest summary info:
|
/publish connector=connectors/source-amazon-seller-partner run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…irbytehq#23605) * add reimbursements stream * bump up version to 0.2.33 and update changelog * add reimbursements stream * bump up version to 0.2.33 and update changelog * bump up version and update changelog * correcting version - incrementing minor version as it adds a new stream to the connector * set additionalProperties to true in the schema * updated expected_records.txt * auto-bump connector version --------- Co-authored-by: Sajarin <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]>
What
Add capability to pull FBA Reimbursement data
How
Add new stream
GET_FBA_REIMBURSEMENTS_DATA
to pull reimbursement data for Amazon seller partnerRecommended reading order
airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.py
airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py
airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/schemas/GET_FBA_REIMBURSEMENTS_DATA.json
airbyte-integrations/connectors/source-amazon-seller-partner/integration_tests/configured_catalog_get_fba_reimbursements_data.json
airbyte-integrations/connectors/source-amazon-seller-partner/acceptance-test-config.yml
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit tests
Integration tests