Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix issues with dashes in name #22803

Merged
merged 4 commits into from
Feb 10, 2023
Merged

fix: fix issues with dashes in name #22803

merged 4 commits into from
Feb 10, 2023

Conversation

xpuska513
Copy link
Contributor

What

  • fix issue where reference to airbyte-bootloader values led to bad chartacter errors
  • fix env-configmap, quote all nubmer and boolean values

Fixes #22699

@octavia-squidington-iii octavia-squidington-iii added area/platform issues related to the platform kubernetes labels Feb 10, 2023
@xpuska513 xpuska513 temporarily deployed to more-secrets February 10, 2023 12:45 — with GitHub Actions Inactive
@xpuska513 xpuska513 temporarily deployed to more-secrets February 10, 2023 12:45 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.67% ❌

mfsiega-airbyte
mfsiega-airbyte approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@mfsiega-airbyte mfsiega-airbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though you'll need to revert my revert as well.

@xpuska513 xpuska513 temporarily deployed to more-secrets February 10, 2023 13:02 — with GitHub Actions Inactive
@xpuska513 xpuska513 temporarily deployed to more-secrets February 10, 2023 13:02 — with GitHub Actions Inactive
@xpuska513 xpuska513 merged commit 858ba2a into master Feb 10, 2023
@xpuska513 xpuska513 deleted the kskobylko/index-dash-in-templates branch February 10, 2023 13:46
@github-actions github-actions bot mentioned this pull request Feb 10, 2023
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 10, 2023
Closed
@domzae domzae mentioned this pull request Feb 12, 2023
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfsiega-airbyte mfsiega-airbyte mfsiega-airbyte approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm chart error: "bad character U+002D '-'" in v0.43.34
3 participants
@xpuska513 @mfsiega-airbyte @octavia-squidington-iii