Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🐛 Add space between job is in progress and schema changes detected indicator in connections table #22667

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

dizel852
Copy link
Contributor

@dizel852 dizel852 commented Feb 9, 2023

What

Resolves #22629

How

Add gap for flex <StatusCell /> container

Before:
Screenshot at Feb 09 20-29-58

After fix:
Screenshot at Feb 09 20-31-02

@dizel852 dizel852 added team/platform-move area/frontend Related to the Airbyte webapp labels Feb 9, 2023
@edmundito
Copy link
Contributor

@dizel852 Looking a lot better but I was wondering if one more thing can be done. When pressing the "sync now" button next to a connection with a breaking/non breaking change indicator will lead the whole table to resize because the column width has changed.

Is it possible to assign a fixed width to that column that can fit all the states so that the table doesn't resize when there's a state change?

@dizel852
Copy link
Contributor Author

@dizel852 Looking a lot better but I was wondering if one more thing can be done. When pressing the "sync now" button next to a connection with a breaking/non breaking change indicator will lead the whole table to resize because the column width has changed.

Is it possible to assign a fixed width to that column that can fit all the states so that the table doesn't resize when there's a state change?

Sure! Will update the fix

@dizel852 dizel852 enabled auto-merge (squash) February 10, 2023 16:07
@dizel852 dizel852 merged commit 6977682 into master Feb 10, 2023
@dizel852 dizel852 deleted the vlad/22629-fix-breaking-changes-icons-cut branch February 10, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/platform-move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Missing space between job is in progress and schema changes detected indicator in connections table
3 participants