🪟 🔧 Add TS CSS modules plugin #22646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
This is a nice extension during development. (Just for posterity: this does not type check when we actually build). pnpm audit showed that this library pulls in some vulnerable new dependencies, so I made sure we're fixing them to their patched versions and pushed it to the PR. Otherwise looks good to me
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds
typescript-plugin-css-modulesso that we get a nice TS-server powered autocomplete & checking of our CSS module files 🎉