-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Ensure the QA check does not influence the report #22150
Merged
bnchrch
merged 1 commit into
master
from
bechurch/feat-qa-engine-remove-script-input-22127
Jan 31, 2023
Merged
[Fix] Ensure the QA check does not influence the report #22150
bnchrch
merged 1 commit into
master
from
bechurch/feat-qa-engine-remove-script-input-22127
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Airbyte Code Coverage
|
/test connector=connectors/source-pokeapi |
/test connector=connectors/source-pokeapi
Build PassedTest summary info:
|
pedroslopez
approved these changes
Jan 31, 2023
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the QA-engine input from the report script to ensure passing builds
related to #22127
How
Disabled in the shell script for now.
Will move to a github action default value in the future.
Chose this way as the script input is testable on my machine, but a complex github action is not.
Post merge