Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-faker to Beta + Fix AllowedHosts Checks #22117

Merged
merged 10 commits into from
Jan 31, 2023
Merged

source-faker to Beta + Fix AllowedHosts Checks #22117

merged 10 commits into from
Jan 31, 2023

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Jan 30, 2023 •
edited
Loading

This PR tests that the allowedHosts checks are working properly. They weren't due to some underlying changes in the python utils...

On a happier note, it looks like Faker is meeting the GA criteria! We shouldn't skip Beta, so let's go there now.

@evantahler evantahler temporarily deployed to more-secrets January 30, 2023 23:11 — with GitHub Actions Inactive
@evantahler evantahler temporarily deployed to more-secrets January 30, 2023 23:11 — with GitHub Actions Inactive
@octavia-squidington-iv octavia-squidington-iv added connectors/source/faker area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jan 30, 2023
@evantahler evantahler temporarily deployed to more-secrets January 30, 2023 23:16 — with GitHub Actions Inactive
@evantahler evantahler temporarily deployed to more-secrets January 30, 2023 23:16 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023 •
edited
Loading

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.51% ❌

@evantahler evantahler temporarily deployed to more-secrets January 30, 2023 23:32 — with GitHub Actions Inactive
@evantahler evantahler temporarily deployed to more-secrets January 30, 2023 23:32 — with GitHub Actions Inactive
@evantahler
Copy link
Contributor Author

evantahler commented Jan 30, 2023 •
edited
Loading

https://github.com/airbytehq/airbyte/actions/runs/4049145884/jobs/6965192810 shows the check doing the right thing for a beta connector with no allowedHosts

Screenshot 2023-01-30 at 3 33 29 PM

The test no longer fails now that allowedHosts is added back

@evantahler evantahler marked this pull request as ready for review January 30, 2023 23:34
@evantahler evantahler requested a review from a team January 30, 2023 23:34
@evantahler evantahler changed the title source-faker to Beta source-faker to Beta + Fix AllowedHosts Checks Jan 30, 2023
@evantahler evantahler temporarily deployed to more-secrets January 30, 2023 23:35 — with GitHub Actions Inactive
@evantahler evantahler temporarily deployed to more-secrets January 30, 2023 23:35 — with GitHub Actions Inactive
@evantahler evantahler requested a review from YowanR January 30, 2023 23:36
bnchrch
bnchrch approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question, 1 nit.

Otherwise:

@evantahler evantahler temporarily deployed to more-secrets January 31, 2023 02:00 — with GitHub Actions Inactive
@evantahler evantahler temporarily deployed to more-secrets January 31, 2023 02:00 — with GitHub Actions Inactive
@evantahler evantahler temporarily deployed to more-secrets January 31, 2023 02:10 — with GitHub Actions Inactive
@evantahler evantahler temporarily deployed to more-secrets January 31, 2023 02:10 — with GitHub Actions Inactive
@evantahler
Copy link
Contributor Author

evantahler commented Jan 31, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/4050865951
❌ connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/4050865951
🐛

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
======================== 35 passed, 2 skipped in 37.42s ========================

@evantahler evantahler temporarily deployed to more-secrets January 31, 2023 04:50 — with GitHub Actions Inactive
@evantahler evantahler temporarily deployed to more-secrets January 31, 2023 04:50 — with GitHub Actions Inactive
@evantahler
Copy link
Contributor Author

The /test command above did pass, but the QA Engine is having trouble. Tracked in #22127

@evantahler
Copy link
Contributor Author

evantahler commented Jan 31, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-faker

🕑 Publishing the following connectors:
connectors/source-faker
https://github.com/airbytehq/airbyte/actions/runs/4051035949


Connector Did it publish? Were definitions generated?
connectors/source-faker ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 31, 2023 05:40 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 31, 2023 05:40 — with GitHub Actions Inactive
@evantahler evantahler enabled auto-merge (squash) January 31, 2023 05:41
@evantahler evantahler merged commit e4f4412 into master Jan 31, 2023
@evantahler evantahler deleted the evan/faker-beta branch January 31, 2023 06:13
bnchrch pushed a commit that referenced this pull request Jan 31, 2023
@evantahler @octavia-squidington-iii @bnchrch
source-faker to Beta + Fix AllowedHosts Checks (#22117)
21995b4 
* beta faker + no allowed hosts

* V2.0.1

* fixup python checks

* add back allowedHosts

* simplify

* simplify releaseStage

* bump expected records

* More mock logger methods

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <[email protected]>
@evantahler
Copy link
Contributor Author

@YowanR no action needed - just calling out that I moved source-faker to beta. It's meeting all the milestones of GA!

@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 2, 2023
Closed
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Closed
This was referenced Feb 8, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnchrch bnchrch bnchrch approved these changes

@YowanR YowanR Awaiting requested review from YowanR

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/faker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evantahler @bnchrch @octavia-squidington-iii @octavia-squidington-iv