Revert "Extend SATs to capture UI limitations (#21451)" #21896

girarda · 2023-01-26T00:27:22Z

This reverts commit fa2c03a.

What

Reverts Extend SATs to capture UI limitations #21451 because SATs are broken

file /Users/alex/code/airbyte/airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py, line 396
      def test_date_format(self, connector_specification: dict, detailed_logger):
E       fixture 'connector_specification' not found
>       available fixtures: acceptance_test_config, actual_connector_spec, base_path, cache, cache_discovered_catalog, cached_schemas, capfd, capfdbinary, caplog, capsys, capsysbinary, class_mocker, configured_catalog, configured_catalog_path, connection_specification, connector_config, connector_config_path, connector_setup, connector_spec, connector_spec_dict, connector_spec_path, cov, detailed_logger, discovered_catalog, docker_runner, doctest_namespace, empty_streams, expect_records_config, expected_records_by_stream, image_tag, invalid_connector_config, invalid_connector_config_path, malformed_connector_config, mocker, module_mocker, monkeypatch, no_cover, package_mocker, previous_cached_schemas, previous_connector_docker_runner, previous_connector_image_name, previous_connector_spec, previous_discovered_catalog, pull_docker_image, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, requests_mock, secret_property_names, session_mocker, skip_backward_compatibility_tests, test_strictness_level, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

This reverts commit fa2c03a.

github-actions · 2023-01-26T00:29:45Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

❌ Sources (63)

Connector	Version	Changelog	Publish
`source-airtable`	`1.0.1`	✅	✅
`source-amazon-ads`	`0.1.27`	✅	✅
`source-amazon-seller-partner`	`0.2.30`	✅	✅
`source-amazon-sqs`	`0.1.0`	✅	✅
`source-amplitude`	`0.1.19`	✅	✅
`source-appsflyer`	`0.1.0`	✅	✅
`source-asana`	`0.1.5`	✅	✅
`source-azure-table`	`0.1.3`	✅	✅
`source-braintree`	`0.1.3`	✅	✅
`source-cart`	`0.2.0`	✅	✅
`source-chargebee`	`0.1.16`	✅	✅
`source-commercetools`	`0.1.0`	✅	✅
`source-confluence`	`0.1.1`	✅	✅
`source-datadog`	`0.1.0`	✅	✅
`source-delighted`	`0.2.0`	✅	✅
`source-drift`	`0.2.5`	✅	✅
`source-facebook-marketing`	`0.2.83`	✅	✅
`source-freshcaller`	`0.1.0`	✅	✅
`source-freshsales`	`0.1.2`	✅	✅
`source-freshservice`	`0.1.1`	✅	✅
`source-github`	`0.3.12`	✅	❌ (diff seed version)
`source-gitlab`	`1.0.1`	✅	✅
`source-google-ads`	`0.2.9`	✅	✅
`source-google-search-console`	`0.1.18`	✅	✅
`source-greenhouse`	`0.3.0`	✅	✅
`source-harvest`	`0.1.14`	✅	✅
`source-instagram`	`1.0.1`	✅	✅
`source-iterable`	`0.1.22`	✅	✅
`source-klaviyo`	`0.1.10`	✅	✅
`source-lemlist`	`0.1.1`	✅	✅
`source-lever-hiring`	`0.1.3`	✅	✅
`source-linnworks`	`0.1.5`	✅	✅
`source-mailchimp`	`0.3.1`	✅	✅
`source-mailgun`	`0.1.0`	✅	✅
`source-monday`	`0.2.2`	✅	✅
`source-notion`	`1.0.0`	✅	✅
`source-okta`	`0.1.14`	✅	✅
`source-onesignal`	`0.1.2`	✅	✅
`source-openweather`	`0.1.6`	✅	✅
`source-outreach`	`0.1.2`	✅	✅
`source-pardot`	`0.1.1`	✅	✅
`source-paystack`	`0.1.1`	✅	✅
`source-pinterest`	`0.2.1`	✅	✅
`source-pipedrive`	`0.1.13`	✅	✅
`source-plaid`	`0.3.2`	✅	✅
`source-posthog`	`0.1.8`	✅	✅
`source-prestashop`	`0.3.0`	✅	✅
`source-quickbooks-singer`	`0.1.5`	✅	✅
`source-recharge`	`0.2.4`	✅	✅
`source-retently`	`0.1.3`	✅	✅
`source-salesforce`	`1.0.29`	✅	✅
`source-salesloft`	`0.1.3`	✅	✅
`source-sendgrid`	`0.3.0`	✅	✅
`source-sentry`	`0.1.8`	✅	✅
`source-strava`	`0.1.2`	✅	✅
`source-surveymonkey`	`0.1.13`	✅	✅
`source-tplcentral`	`0.1.1`	✅	✅
`source-twilio`	`0.1.14`	✅	✅
`source-weatherstack`	`0.1.0`	✅	✅
`source-youtube-analytics`	`0.1.3`	✅	✅
`source-zendesk-sunshine`	`0.1.1`	✅	✅
`source-zendesk-talk`	`0.1.5`	✅	✅
`source-zenloop`	`0.1.4`	✅	✅

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

girarda · 2023-01-26T00:31:58Z

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/4011186511
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/4011186511
No Python unittests run

Build Passed

Test summary info:

All Passed

girarda · 2023-01-26T00:32:53Z

tested locally on airtable

=========================== short test summary info ============================
SKIPPED [1] ../../bases/source-acceptance-test/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../../bases/source-acceptance-test/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../../bases/source-acceptance-test/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============ 26 passed, 3 skipped, 54 warnings in 68.45s (0:01:08) =============

brianjlai

lgtm

girarda · 2023-01-26T01:05:11Z

/publish connector=bases/source-acceptance-test auto-bump-version=false

🕑 Publishing the following connectors:
bases/source-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/4011361441

Connector	Did it publish?	Were definitions generated?
bases/source-acceptance-test	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…)" This reverts commit 74b5dbf.

* Revert "Revert "Extend SATs to capture UI limitations (#21451)" (#21896)" This reverts commit 74b5dbf. * fix fixture problem

girarda added 2 commits January 25, 2023 16:26

Revert "Extend SATs to capture UI limitations (#21451)"

67e3fc0

This reverts commit fa2c03a.

bump to 0.4.0

ea66cee

girarda marked this pull request as ready for review January 26, 2023 00:29

girarda requested review from flash1293, alafanechere and brianjlai January 26, 2023 00:29

brianjlai approved these changes Jan 26, 2023

View reviewed changes

girarda enabled auto-merge (squash) January 26, 2023 00:33

girarda merged commit 74b5dbf into master Jan 26, 2023

girarda deleted the alex/revert_new_sat branch January 26, 2023 00:47

girarda restored the alex/revert_new_sat branch January 26, 2023 01:04

flash1293 pushed a commit that referenced this pull request Jan 26, 2023

Revert "Revert "Extend SATs to capture UI limitations (#21451)" (#21896…

6e3809c

…)" This reverts commit 74b5dbf.

This was referenced Jan 27, 2023

Bump Airbyte version from 0.40.29 to 0.40.30 #21954

Closed

Bump Airbyte version from 0.40.29 to 0.40.30 #21991

Closed

Bump Airbyte version from 0.40.29 to 0.40.30 #22045

Merged

flash1293 pushed a commit that referenced this pull request Jan 30, 2023

Extend SATs to capture UI limitations - fixed version (#21903)

63064d9

* Revert "Revert "Extend SATs to capture UI limitations (#21451)" (#21896)" This reverts commit 74b5dbf. * fix fixture problem

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Extend SATs to capture UI limitations (#21451)" #21896

Revert "Extend SATs to capture UI limitations (#21451)" #21896

girarda commented Jan 26, 2023

github-actions bot commented Jan 26, 2023 •

edited

Loading

❌ Sources (63)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

girarda commented Jan 26, 2023 •

edited by github-actions bot

Loading

girarda commented Jan 26, 2023

brianjlai left a comment

girarda commented Jan 26, 2023 •

edited by github-actions bot

Loading

Revert "Extend SATs to capture UI limitations (#21451)" #21896

Revert "Extend SATs to capture UI limitations (#21451)" #21896

Conversation

girarda commented Jan 26, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

github-actions bot commented Jan 26, 2023 • edited Loading

Affected Connector Report

❌ Sources (63)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

girarda commented Jan 26, 2023 • edited by github-actions bot Loading

Build Passed

girarda commented Jan 26, 2023

brianjlai left a comment

Choose a reason for hiding this comment

girarda commented Jan 26, 2023 • edited by github-actions bot Loading

github-actions bot commented Jan 26, 2023 •

edited

Loading

girarda commented Jan 26, 2023 •

edited by github-actions bot

Loading

girarda commented Jan 26, 2023 •

edited by github-actions bot

Loading